[codeInsight] IDEA-113640 Provide intention to combine System.out.println(String.format(...)) into System.out.printf

This patch adds processing of Java 14's text blocks to RedundantStringFormatCallInspection and fixes the problems from the code review

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 126cfc001e7b201b62060333de7f71480403fb93
This commit is contained in:
Nikita Eshkeev
2020-05-07 22:24:17 +03:00
committed by intellij-monorepo-bot
parent c8bc41207e
commit 8db5967f7b
13 changed files with 479 additions and 99 deletions

View File

@@ -0,0 +1,64 @@
// "Fix all 'Redundant call to 'String.format()'' problems in file" "true"
package java.lang;
import java.io.PrintStream;
class String {
String(Object original) {}
public native String formatted(Object... args);
}
class Main {
static {
/* one */
System.out.printf(/* three */(new String("""
%s, %s!
"""/* two */)) + "%n", "Hello"/* four */, /* six */ "World" /* seven */);
/* one */
System.out.printf(/* six */( /* two */ ( /* three */ new String("""
%s, %s!
"""/* four */) /* five */)), "Hello"/* seven */, /* eight */ "World" /* nine */);
/* one */
System.out.printf(/* six */new String("""
%s, %s!
"""/* two */), "Hello"/* seven */, /* eight */ "World" /* nine */);
System.out.printf(/* five */( /* one */ new String("""
%s,
""" /* two */) + /* three */
new String("""
%s!
""") + "%n"/* four */), "Hello"/* six */, /* seven */ "World" /* eight */);
System.out.printf(/* five */( /* one */ new String("""
%s,
""" /* two */) + new String(/* three */
"""
%s!
""")/* four */), "Hello"/* six */, /* seven */ "World" /* eight */);
}
Main() {
}
void f() {
}
void out(PrintStream printer) {
}
void caller() {
println(( /* one */ new String("""
%s,
""" /* two */ + /* three */
"""
%s!
"""/* four */)).formatted(/* five */"Hello"/* six */, /* seven */ "World" /* eight */));
}
static void println(String value) {}
}