improve "Unknown @GuardedBy field" inspection

java/java-tests/testData/inspection/unknownGuard/UnknownGuard.java

@@ -0,0 +1,83 @@
+import javax.annotation.concurrent.*;
+
+class UnknownGuard {
+  @GuardedBy("itself")
+  private final Object one = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"nothing\"">"nothing"</warning>)
+  private Object two = new Object();
+
+  @GuardedBy("this")
+  private Object three = new Object();
+
+  @GuardedBy("UnknownGuard.this")
+  private Object four = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"Nothing.this\"">"Nothing.this"</warning>)
+  private Object five = new Object();
+
+  @GuardedBy("lock()")
+  private Object six = new Object();
+  private Object lock() {
+    return new Object();
+  }
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"wrong()\"">"wrong()"</warning>)
+  private Object seven = new Object();
+  private void wrong() {}
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"wrong2()\"">"wrong2()"</warning>)
+  private Object eight = new Object();
+  private void wrong2(int i) {}
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"nothing()\"">"nothing()"</warning>)
+  private Object nine = new Object();
+
+  @GuardedBy("one")
+  private Object ten = new Object();
+
+  @GuardedBy("this.one")
+  private Object eleven = new Object();
+
+  @GuardedBy("UnknownGuard.this.one")
+  private Object twelve = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"wrong\"">"wrong"</warning>)
+  private Object thirteen = new Object();
+  private int wrong = 1;
+
+  @GuardedBy("java.lang.String.class")
+  private Object fourteen = new Object();
+
+  @GuardedBy("UnknownGuard.class")
+  private Object fifteen = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"Nothing.class\"">"Nothing.class"</warning>)
+  private Object sixteen = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"Wrong.this\"">"Wrong.this"</warning>)
+  private Object seventeen = new Object();
+  class Wrong {}
+
+  /**
+   * <warning descr="Unknown @GuardedBy reference \"wrong\"">@GuardedBy(wrong)</warning>
+   */
+  private Object eighteen = new Object();
+
+  /**
+   * @GuardedBy(this)
+   */
+  private Object nineteen = new Object();
+
+  @GuardedBy("Inner.LOCK")
+  private Object twenty = new Object();
+  static class Inner {
+    private static final Object LOCK = new Object();
+  }
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"Inner.nothing\"">"Inner.nothing"</warning>)
+  private Object twentyone = new Object();
+
+  @GuardedBy(<warning descr="Unknown @GuardedBy reference \"Nothing.LOCK\"">"Nothing.LOCK"</warning>)
+  private Object twentytwo = new Object();
+}

java/java-tests/testSrc/com/intellij/codeInspection/UnknownGuardInspectionTest.java

@@ -0,0 +1,54 @@
+/*
+ * Copyright 2000-2016 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * (c) 2016 Silent Forest AB
+ * created: 18 March 2016
+ */
+package com.intellij.codeInspection;
+
+import com.intellij.JavaTestUtil;
+import com.intellij.codeInspection.concurrencyAnnotations.UnknownGuardInspection;
+import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * @author Bas Leijdekkers
+ */
+public class UnknownGuardInspectionTest extends LightCodeInsightFixtureTestCase {
+
+  public void testUnknownGuard() {
+    myFixture.testHighlighting(true, false, false, getTestName(false) + ".java");
+  }
+
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+    myFixture.enableInspections(new UnknownGuardInspection());
+    myFixture.addClass("package javax.annotation.concurrent;\n" +
+                       "@java.lang.annotation.Target({java.lang.annotation.ElementType.FIELD, java.lang.annotation.ElementType.METHOD})\n" +
+                       "@java.lang.annotation.Retention(java.lang.annotation.RetentionPolicy.RUNTIME)\n" +
+                       "public @interface GuardedBy {\n" +
+                       "    java.lang.String value();\n" +
+                       "}");
+  }
+
+  @NotNull
+  @Override
+  protected String getTestDataPath() {
+    return JavaTestUtil.getJavaTestDataPath() + "/inspection/unknownGuard";
+  }
+}