MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-22734 Don't capture local variable in the lambda used as a cached value provider

Browse Source 
Otherwise, we re-compute the function's result type using a stale type
comment.
This commit is contained in:
Mikhail Golubev
2017-04-17 14:13:22 +03:00
parent a3ac0e0532
commit 86d84f6f65
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/codeInsight/typing/PyTypingTypeProvider.java
+2 -5
View File
@@ -23,10 +23,7 @@ import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Ref;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiPolyVariantReference;
import com.intellij.psi.util.CachedValueProvider;
import com.intellij.psi.util.CachedValuesManager;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.QualifiedName;
import com.intellij.psi.util.*;
import com.intellij.util.containers.ContainerUtil;
import com.intellij.util.containers.HashMap;
import com.intellij.util.containers.HashSet;
@@ -285,7 +282,7 @@ public class PyTypingTypeProvider extends PyTypeProviderBase {
return null;
}
final PyFunctionTypeAnnotationFile file = CachedValuesManager.getCachedValue(function, () ->
CachedValueProvider.Result.create(new PyFunctionTypeAnnotationFile(comment, function), function));
CachedValueProvider.Result.create(new PyFunctionTypeAnnotationFile(function.getTypeCommentAnnotation(), function), function));
return file.getAnnotation();
}