This commit is contained in:
Maxim Shafirov
2012-04-19 15:41:40 +04:00
parent 0d7cc22ae6
commit 859f1f3a3f
36 changed files with 10 additions and 244 deletions
@@ -60,10 +60,6 @@ public class ExplicitTypeCanBeDiamondInspection extends BaseJavaLocalInspectionT
@Override
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new JavaElementVisitor() {
@Override
public void visitReferenceExpression(PsiReferenceExpression expression) {
}
@Override
public void visitNewExpression(PsiNewExpression expression) {
if (PsiDiamondTypeUtil.canCollapseToDiamond(expression, expression, null)) {
@@ -170,9 +170,5 @@ public class PossibleHeapPollutionVarargsInspection extends BaseJavaLocalInspect
}
protected abstract void registerProblem(PsiMethod method, PsiIdentifier nameIdentifier);
@Override
public void visitReferenceExpression(PsiReferenceExpression expression) {
}
}
}
@@ -70,9 +70,6 @@ public class DataFlowInspection extends BaseLocalInspectionTool {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new JavaElementVisitor() {
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {}
@Override public void visitField(PsiField field) {
if (isNullLiteralExpression(field.getInitializer()) && NullableNotNullManager.isNotNull(field)) {
holder.registerProblem(field.getInitializer(), InspectionsBundle.message("dataflow.message.initializing.field.with.null"));
@@ -29,7 +29,6 @@ import com.intellij.codeInspection.dataFlow.DfaInstructionState;
import com.intellij.codeInspection.dataFlow.DfaMemoryState;
import com.intellij.codeInspection.dataFlow.InstructionVisitor;
import com.intellij.openapi.progress.ProgressManager;
import org.jetbrains.annotations.NonNls;
import java.util.ArrayList;
@@ -71,9 +70,4 @@ public abstract class Instruction {
public int getIndex() {
return myIndex;
}
@NonNls
public String toString() {
return super.toString();
}
}
@@ -62,8 +62,6 @@ public class DefUseInspection extends BaseLocalInspectionTool {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, final boolean isOnTheFly) {
return new JavaElementVisitor() {
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {}
@Override public void visitMethod(PsiMethod method) {
checkCodeBlock(method.getBody(), holder, isOnTheFly);
}
@@ -44,9 +44,6 @@ public class DuplicateThrowsInspection extends BaseLocalInspectionTool {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new JavaElementVisitor() {
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
}
@Override public void visitMethod(PsiMethod method) {
PsiReferenceList throwsList = method.getThrowsList();
PsiJavaCodeReferenceElement[] refs = throwsList.getReferenceElements();
@@ -95,10 +95,6 @@ public class EqualsAndHashcode extends BaseJavaLocalInspectionTool {
(LocalQuickFix[])null);
}
}
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
//do nothing
}
};
}
@@ -60,10 +60,6 @@ public class UndesirableClassUsageInspection extends InternalInspection {
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
if (!ApplicationManagerEx.getApplicationEx().isInternal()) return new JavaElementVisitor() {};
return new JavaElementVisitor() {
@Override
public void visitReferenceExpression(PsiReferenceExpression expression) {
}
@Override
public void visitNewExpression(PsiNewExpression expression) {
PsiJavaCodeReferenceElement ref = expression.getClassReference();
@@ -67,9 +67,6 @@ public class NullableStuffInspection extends BaseLocalInspectionTool {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new JavaElementVisitor() {
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
}
@Override public void visitMethod(PsiMethod method) {
if (!PsiUtil.isLanguageLevel5OrHigher(method)) return;
checkNullableStuffForMethod(method, holder);
@@ -117,10 +117,6 @@ public class SuspiciousNameCombinationInspection extends BaseLocalInspectionTool
public MyVisitor(final ProblemsHolder problemsHolder) {
myProblemsHolder = problemsHolder;
}
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
}
@Override public void visitVariable(PsiVariable variable) {
if (variable.hasInitializer()) {
PsiExpression expr = variable.getInitializer();
@@ -50,9 +50,6 @@ public class TestOnlyInspection extends BaseJavaLocalInspectionTool {
@Override public void visitCallExpression(PsiCallExpression e) {
validate(e, h);
}
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
}
};
}
@@ -108,4 +105,4 @@ public class TestOnlyInspection extends BaseJavaLocalInspectionTool {
String message = InspectionsBundle.message("inspection.test.only.problems.test.only.method.call");
h.registerProblem(e, message, ProblemHighlightType.GENERIC_ERROR_OR_WARNING);
}
}
}
@@ -17,12 +17,7 @@ package com.intellij.cyclicDependencies.ui;
import com.intellij.analysis.AnalysisScopeBundle;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.packageDependencies.ui.PackageDependenciesNode;
import com.intellij.psi.PsiFile;
import javax.swing.*;
import java.util.Set;
/**
* User: anna
@@ -33,26 +28,6 @@ public class CycleNode extends PackageDependenciesNode{
super(project);
}
public void fillFiles(Set<PsiFile> set, boolean recursively) {
super.fillFiles(set, recursively);
}
public void addFile(VirtualFile file, boolean isMarked) {
super.addFile(file, isMarked);
}
public Icon getOpenIcon() {
return super.getOpenIcon();
}
public Icon getClosedIcon() {
return super.getClosedIcon();
}
public int getWeight() {
return super.getWeight();
}
public String toString() {
return AnalysisScopeBundle.message("cyclic.dependencies.tree.cycle.node.text");
}
@@ -94,10 +94,6 @@ public class ClassesScopeTreeStructureExpander implements ScopeTreeStructureExpa
@Override public void visitField(PsiField field) {
classNode.add(new FieldNode(field));
}
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
}
});
}
}
@@ -961,14 +961,6 @@ public class InheritanceToDelegationProcessor extends BaseRefactoringProcessor {
myInstanceVisitor = instanceScanner;
}
@Override public void visitTypeElement(PsiTypeElement type) {
super.visitTypeElement (type);
}
@Override public void visitReferenceElement(PsiJavaCodeReferenceElement element) {
super.visitReferenceElement (element);
}
protected void visitClassMemberReferenceElement(PsiMember classMember, PsiJavaCodeReferenceElement classMemberReference) {
if ("super".equals(classMemberReference.getText()) && classMemberReference.getParent() instanceof PsiMethodCallExpression) {
return;
@@ -75,9 +75,6 @@ public class InlineParameterExpressionProcessor extends BaseRefactoringProcessor
return InlineParameterHandler.REFACTORING_NAME;
}
@Override
protected void refreshElements(PsiElement[] elements) {
}
@NotNull
@Override
@@ -945,7 +945,7 @@ public class RefactoringUtil {
return false;
}
public static interface ImplicitConstructorUsageVisitor {
public interface ImplicitConstructorUsageVisitor {
void visitConstructor(PsiMethod constructor, PsiMethod baseConstructor);
void visitClassWithoutConstructors(PsiClass aClass);