MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-17 20:11:25 +07:00
Code Issues Packages Projects Releases Wiki Activity

[debugger] do not leak results values in helper - do not create anonymous classes

Browse Source 
GitOrigin-RevId: 798db72789f5517033023383160627e3cbf42890
This commit is contained in:
Egor Ushakov
2025-02-11 18:50:06 +01:00
committed by intellij-monorepo-bot
parent 08e60ab334
commit 8513706464
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
java/java-runtime/src/com/intellij/rt/debugger/MethodInvoker.java
View File

@@ -12,12 +12,14 @@ import java.util.List;
@SuppressWarnings({"SSBasedInspection", "unused"})
public final class MethodInvoker {
private static final ThreadLocal<List<Object>> keptValues = new ThreadLocal<List<Object>>() {
@Override
protected List<Object> initialValue() {
return new LinkedList<>(); // LinkedList for fast elements removal
}
};
private static final ThreadLocal<List<Object>> keptValues = new ThreadLocal<>();
// Do not create an anonymous class here to simplify helper class loading into the target process
//{
// @Override
// protected List<Object> initialValue() {
// return new LinkedList<>(); // LinkedList for fast elements removal
// }
//};
public static Object invoke0(MethodHandles.Lookup lookup, Class<?> cls, Object obj, String nameAndDescriptor, ClassLoader loader)
throws Throwable {
@@ -234,6 +236,10 @@ public final class MethodInvoker {
private static Object keepReference(Object ref, boolean soft) {
List<Object> objects = keptValues.get();
if (objects == null) {
objects = new LinkedList<>();
keptValues.set(objects);
}
removeStaleReferences(objects);
Object wrapper = soft ? new SoftReference<>(ref) : new Object[]{ref};
objects.add(wrapper);