MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-02 04:35:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

[rename] don't search for test methods for classes with names which occur too often

Browse Source 
not only the class with the function is checked, but also all overridings

^KTIJ-31589 fixed

GitOrigin-RevId: 3fb21fa787e80656abb706bdc964ea64e179bf89
This commit is contained in:
Anna Kozlova
2024-10-11 09:59:27 +00:00
committed by intellij-monorepo-bot
parent 0e3d00dce5
commit 81ffdbb0c0
12 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl-refactorings/src/com/intellij/refactoring/rename/naming/AutomaticTestMethodRenamerFactory.kt
+5 -5
View File
@@ -22,16 +22,14 @@ abstract class AutomaticTestMethodRenamerFactory : AutomaticRenamerFactory {
protected class AutomaticTestMethodRenamer(oldMethodName: String?,
className: String?,
module: Module?,
newMethodName: String,
namesToSkip: Set<String> = emptySet()) : AutomaticRenamer() {
newMethodName: String) : AutomaticRenamer() {
init {
findMethodsToReplace(oldMethodName, className, module, namesToSkip)
findMethodsToReplace(oldMethodName, className, module)
suggestAllNames(oldMethodName, newMethodName)
}
private fun findMethodsToReplace(oldMethodName: String?, className: String?, module: Module?, namesToSkip: Set<String>) {
private fun findMethodsToReplace(oldMethodName: String?, className: String?, module: Module?) {
if (oldMethodName == null || className == null || module == null) return
if (namesToSkip.contains(className)) return
val moduleScope = GlobalSearchScope.moduleWithDependentsScope(module)
val cache = PsiShortNamesCache.getInstance(module.getProject())
@@ -39,8 +37,10 @@ abstract class AutomaticTestMethodRenamerFactory : AutomaticRenamerFactory {
val classPattern = Pattern.compile(".*$className.*")
val methodPattern = Pattern.compile(".*$oldMethodName.*", Pattern.CASE_INSENSITIVE)
var count = 0
for (eachName in ContainerUtil.newHashSet(*cache.getAllClassNames())) {
if (classPattern.matcher(eachName).matches()) {
if (count ++ > 1000) break
for (eachClass in cache.getClassesByName(eachName, moduleScope)) {
if (TestFrameworks.detectFramework(eachClass) != null) {
eachClass.methods.forEach {