MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: remove redundant notification group

Browse Source 
GitOrigin-RevId: 4b9e77b1d31c15aa6619885050c5c2b9b37d74f6
This commit is contained in:
Dmitry Jemerov
2022-06-10 18:18:00 +02:00
committed by intellij-monorepo-bot
parent 114a12a3a1
commit 8043c4bbd9
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
notebooks/visualization/resources/intellij.notebooks.visualization.xml
View File

@@ -75,7 +75,6 @@
<extensions defaultExtensionNs="com.intellij">
<notificationGroup displayType="BALLOON" id="Notebook Table" bundle="messages.VisualizationBundle" key="inlay.output.table.notification.group.name"/>
<notificationGroup id="InlayTable" displayType="BALLOON"/>
<editorFactoryListener id="org.jetbrains.plugins.notebooks.visualization.r.inlays.InlaysManager" implementation="org.jetbrains.plugins.notebooks.visualization.r.inlays.InlaysManager"/>
<editorFactoryMouseListener

2
notebooks/visualization/resources/messages/VisualizationBundle.properties
View File

@@ -8,7 +8,7 @@ inlay.output.export.failure.description=Cannot save to the selected destination
inlay.output.image.export.title=Export Image
inlay.output.image.export.description=Save image to disk
inlay.output.table.notification.group.name=Notebook Table
inlay.output.table.notification.group.name=Notebook table
inlay.table.copy.all=Copy all
inlay.table.copy.selected=Copy selected
inlay.table.export.as.text=Export As

5
notebooks/visualization/src/org/jetbrains/plugins/notebooks/visualization/r/inlays/ClipboardUtils.kt
View File

@@ -27,8 +27,7 @@ object ClipboardUtils {
private fun copyAllToString(table: JTable, cellBreak: String = CELL_BREAK, limit: Int = Int.MAX_VALUE): String {
if (table.rowCount == 0 || table.columnCount == 0) {
// The code should be compatible with 193 and 201 so, so we cannot use NotificationGroup.createIdWithTitle yet
// NotificationGroup.createIdWithTitle("Notebook Table", VisualizationBundle.message("inlay.output.table.notification.group.name"))
Notifications.Bus.notify(Notification(VisualizationBundle.message("inlay.output.table.notification.group.name"),
Notifications.Bus.notify(Notification("Notebook Table",
VisualizationBundle.message("clipboard.utils.error"),
VisualizationBundle.message("clipboard.utils.no.columns.or.rows"),
NotificationType.ERROR))
@@ -69,7 +68,7 @@ object ClipboardUtils {
val selectedColumns = table.selectedColumns
if (selectedColumnCount == 0 || selectedRowCount == 0) {
Notifications.Bus.notify(Notification("InlayTable",
Notifications.Bus.notify(Notification("Notebook Table",
VisualizationBundle.message("clipboard.utils.error"),
VisualizationBundle.message("clipboard.utils.no.selection"),
NotificationType.ERROR))