MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-30 18:28:55 +07:00
Code Issues Packages Projects Releases Wiki Activity

[inspections] support property syntax for unused return value (IDEA-294487)

Browse Source 
GitOrigin-RevId: 0d1d9df9cc1c9cd59b19b3a43e14cfe5b6bd47ac
This commit is contained in:
Anna Kozlova
2022-05-23 11:10:56 +02:00
committed by intellij-monorepo-bot
parent c78be8f843
commit 7e11fe7574
4 changed files with 49 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
java/java-analysis-impl/src/com/intellij/codeInspection/reference/RefJavaUtilImpl.java
View File

@@ -442,7 +442,7 @@ public class RefJavaUtilImpl extends RefJavaUtil {
private void updateRefMethod(PsiElement psiResolved,
RefMethodImpl refMethod,
UExpression refExpression,
@NotNull UExpression refExpression,
final UElement uFrom) {
UMethod uMethod = Objects.requireNonNull(UastContextKt.toUElement(psiResolved, UMethod.class));
refMethod.waitForInitialized();
@@ -467,6 +467,16 @@ public class RefJavaUtilImpl extends RefJavaUtil {
return;
}
PsiType returnType = uMethod.getReturnType();
if (!uMethod.isConstructor() && !PsiType.VOID.equals(returnType)) {
PsiExpression expression = ObjectUtils.tryCast(refExpression.getJavaPsi(), PsiExpression.class);
if (expression == null || !ExpressionUtils.isVoidContext(expression)) {
refMethod.setReturnValueUsed(true);
}
addTypeReference(uFrom, returnType, refMethod.getRefManager());
}
UCallExpression call = null;
if (refExpression instanceof UCallExpression) {
call = (UCallExpression)refExpression;
@@ -475,16 +485,6 @@ public class RefJavaUtilImpl extends RefJavaUtil {
call = ObjectUtils.tryCast(((UQualifiedReferenceExpression)refExpression).getSelector(), UCallExpression.class);
}
if (call != null) {
PsiType returnType = uMethod.getReturnType();
if (!uMethod.isConstructor() && !PsiType.VOID.equals(returnType)) {
PsiExpression expression = ObjectUtils.tryCast(call.getJavaPsi(), PsiExpression.class);
if (expression == null || !ExpressionUtils.isVoidContext(expression)) {
refMethod.setReturnValueUsed(true);
}
addTypeReference(uFrom, returnType, refMethod.getRefManager());
}
List<UExpression> argumentList = call.getValueArguments();
if (!argumentList.isEmpty()) {
refMethod.updateParameterValues(argumentList, psiResolved);