mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
Merge remote-tracking branch 'origin/master' into meanmail/EDU-839
This commit is contained in:
@@ -13,7 +13,6 @@
|
||||
<orderEntry type="library" name="gson" level="project" />
|
||||
<orderEntry type="module" module-name="educational-python" />
|
||||
<orderEntry type="module" module-name="python-community-configure" />
|
||||
<orderEntry type="module" module-name="course-creator" />
|
||||
<orderEntry type="module" module-name="educational-core" />
|
||||
<orderEntry type="module" module-name="python-community-ide" />
|
||||
</component>
|
||||
|
||||
@@ -35,7 +35,6 @@
|
||||
<importResolver implementation="com.jetbrains.edu.learning.PyStudyImportResolver"/>
|
||||
</extensions>
|
||||
<extensions defaultExtensionNs="Edu">
|
||||
<StudyExecutor implementationClass="com.jetbrains.edu.learning.PyStudyExecutor" language="Python"/>
|
||||
<pluginConfigurator implementationClass="com.jetbrains.edu.learning.PyEduPluginConfigurator" language="Python"/>
|
||||
<eduProjectCreator implementation="com.jetbrains.edu.learning.builtInServer.EduPythonProjectCreator"/>
|
||||
</extensions>
|
||||
|
||||
+5
-5
@@ -77,10 +77,10 @@ public class PyEduPluginConfigurator implements EduPluginConfigurator {
|
||||
@Override
|
||||
public boolean isTestFile(VirtualFile file) {
|
||||
String name = file.getName();
|
||||
if (EduNames.TESTS_FILE.equals(name)) {
|
||||
if (TESTS_PY.equals(name)) {
|
||||
return true;
|
||||
}
|
||||
return name.contains(FileUtil.getNameWithoutExtension(EduNames.TESTS_FILE)) && name.contains(EduNames.SUBTASK_MARKER);
|
||||
return name.contains(FileUtil.getNameWithoutExtension(TESTS_PY)) && name.contains(EduNames.SUBTASK_MARKER);
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -94,7 +94,7 @@ public class PyEduPluginConfigurator implements EduPluginConfigurator {
|
||||
ApplicationManager.getApplication().runWriteAction(() -> {
|
||||
try {
|
||||
PsiDirectory taskPsiDir = PsiManager.getInstance(project).findDirectory(taskDir);
|
||||
FileTemplate testsTemplate = FileTemplateManager.getInstance(project).getInternalTemplate(EduNames.TESTS_FILE);
|
||||
FileTemplate testsTemplate = FileTemplateManager.getInstance(project).getInternalTemplate(TESTS_PY);
|
||||
if (taskPsiDir == null || testsTemplate == null) {
|
||||
return;
|
||||
}
|
||||
@@ -108,10 +108,10 @@ public class PyEduPluginConfigurator implements EduPluginConfigurator {
|
||||
|
||||
@NotNull
|
||||
public static String getSubtaskTestsFileName(int index) {
|
||||
return index == 0 ? EduNames.TESTS_FILE : FileUtil.getNameWithoutExtension(EduNames.TESTS_FILE) +
|
||||
return index == 0 ? TESTS_PY : FileUtil.getNameWithoutExtension(TESTS_PY) +
|
||||
EduNames.SUBTASK_MARKER +
|
||||
index + "." +
|
||||
FileUtilRt.getExtension(EduNames.TESTS_FILE);
|
||||
FileUtilRt.getExtension(TESTS_PY);
|
||||
}
|
||||
|
||||
@NotNull
|
||||
|
||||
+3
-34
@@ -6,7 +6,6 @@ import com.intellij.openapi.command.CommandProcessor;
|
||||
import com.intellij.openapi.diagnostic.Logger;
|
||||
import com.intellij.openapi.progress.ProgressManager;
|
||||
import com.intellij.openapi.project.Project;
|
||||
import com.intellij.openapi.ui.MessageType;
|
||||
import com.intellij.openapi.vfs.VirtualFile;
|
||||
import com.intellij.openapi.wm.IdeFocusManager;
|
||||
import com.jetbrains.edu.learning.actions.StudyCheckAction;
|
||||
@@ -15,14 +14,10 @@ import com.jetbrains.edu.learning.checker.StudyCheckUtils;
|
||||
import com.jetbrains.edu.learning.checker.StudyTestRunner;
|
||||
import com.jetbrains.edu.learning.core.EduNames;
|
||||
import com.jetbrains.edu.learning.courseFormat.Course;
|
||||
import com.jetbrains.edu.learning.courseFormat.StudyStatus;
|
||||
import com.jetbrains.edu.learning.courseFormat.TaskFile;
|
||||
import com.jetbrains.edu.learning.courseFormat.tasks.ChoiceTask;
|
||||
import com.jetbrains.edu.learning.courseFormat.tasks.Task;
|
||||
import com.jetbrains.edu.learning.editor.StudyChoiceVariantsPanel;
|
||||
import com.jetbrains.edu.learning.editor.StudyEditor;
|
||||
import com.jetbrains.edu.learning.statistics.EduUsagesCollector;
|
||||
import com.jetbrains.edu.learning.ui.StudyToolWindow;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
|
||||
@@ -52,7 +47,7 @@ public class PyStudyCheckAction extends StudyCheckAction {
|
||||
ApplicationManager.getApplication().invokeLater(
|
||||
() -> IdeFocusManager.getInstance(project).requestFocus(studyState.getEditor().getComponent(), true));
|
||||
|
||||
final StudyTestRunner testRunner = StudyUtils.getTestRunner(task, taskDir);
|
||||
final StudyTestRunner testRunner = new PyStudyTestRunner(task, taskDir);
|
||||
Process testProcess = null;
|
||||
String commandLine = "";
|
||||
try {
|
||||
@@ -83,9 +78,9 @@ public class PyStudyCheckAction extends StudyCheckAction {
|
||||
return new StudyCheckTask(project, studyState, myCheckInProgress, testProcess, commandLine) {
|
||||
@Override
|
||||
protected void onTaskFailed(@NotNull String message) {
|
||||
super.onTaskFailed(message);
|
||||
ApplicationManager.getApplication().invokeLater(() -> {
|
||||
if (myTaskDir == null) return;
|
||||
myTask.setStatus(StudyStatus.Failed);
|
||||
for (Map.Entry<String, TaskFile> entry : myTask.getTaskFiles().entrySet()) {
|
||||
final String name = entry.getKey();
|
||||
final TaskFile taskFile = entry.getValue();
|
||||
@@ -99,38 +94,12 @@ public class PyStudyCheckAction extends StudyCheckAction {
|
||||
() -> StudyCheckUtils.runSmartTestProcess(myTaskDir, testRunner, name, taskFile, project)));
|
||||
}
|
||||
}
|
||||
final StudyToolWindow toolWindow = StudyUtils.getStudyToolWindow(project);
|
||||
if (toolWindow != null) {
|
||||
final Course course = StudyTaskManager.getInstance(project).getCourse();
|
||||
if (course != null) {
|
||||
if (course.isAdaptive()) {
|
||||
if (myTask instanceof ChoiceTask) {
|
||||
StudyCheckUtils.showTestResultPopUp("Wrong answer", MessageType.ERROR.getPopupBackground(), project);
|
||||
repaintChoicePanel(project, (ChoiceTask)myTask);
|
||||
}
|
||||
else {
|
||||
StudyCheckUtils.showTestResultPopUp("Wrong answer", MessageType.ERROR.getPopupBackground(), project);
|
||||
StudyCheckUtils.showTestResultsToolWindow(project, message, false);
|
||||
}
|
||||
}
|
||||
else {
|
||||
StudyCheckUtils.showTestResultPopUp(message, MessageType.ERROR.getPopupBackground(), project);
|
||||
}
|
||||
}
|
||||
StudyCheckUtils.navigateToFailedPlaceholder(myStudyState, myTask, myTaskDir, project);
|
||||
}
|
||||
StudyCheckUtils.navigateToFailedPlaceholder(myStudyState, myTask, myTaskDir, project);
|
||||
});
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
private static void repaintChoicePanel(@NotNull Project project, @NotNull ChoiceTask task) {
|
||||
final StudyToolWindow toolWindow = StudyUtils.getStudyToolWindow(project);
|
||||
if (toolWindow != null) {
|
||||
toolWindow.setBottomComponent(new StudyChoiceVariantsPanel(task));
|
||||
}
|
||||
}
|
||||
|
||||
@Nullable
|
||||
private static VirtualFile getTaskVirtualFile(@NotNull final StudyState studyState,
|
||||
@NotNull final Task task,
|
||||
|
||||
-96
@@ -1,96 +0,0 @@
|
||||
/*
|
||||
* Copyright 2000-2014 JetBrains s.r.o.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package com.jetbrains.edu.learning;
|
||||
|
||||
import com.intellij.execution.RunContentExecutor;
|
||||
import com.intellij.execution.configurations.GeneralCommandLine;
|
||||
import com.intellij.execution.process.ProcessHandler;
|
||||
import com.intellij.openapi.application.ApplicationManager;
|
||||
import com.intellij.openapi.module.ModuleManager;
|
||||
import com.intellij.openapi.options.ShowSettingsUtil;
|
||||
import com.intellij.openapi.project.Project;
|
||||
import com.intellij.openapi.projectRoots.Sdk;
|
||||
import com.intellij.openapi.ui.MessageType;
|
||||
import com.intellij.openapi.ui.popup.Balloon;
|
||||
import com.intellij.openapi.ui.popup.BalloonBuilder;
|
||||
import com.intellij.openapi.ui.popup.JBPopupFactory;
|
||||
import com.intellij.openapi.vfs.VirtualFile;
|
||||
import com.jetbrains.edu.learning.courseFormat.tasks.Task;
|
||||
import com.jetbrains.edu.learning.checker.StudyExecutor;
|
||||
import com.jetbrains.edu.learning.checker.StudyTestRunner;
|
||||
import com.jetbrains.edu.learning.courseFormat.UserTest;
|
||||
import com.jetbrains.python.run.PythonTracebackFilter;
|
||||
import com.jetbrains.python.sdk.PythonSdkType;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
|
||||
import javax.swing.event.HyperlinkEvent;
|
||||
import java.io.File;
|
||||
import java.util.List;
|
||||
|
||||
public class PyStudyExecutor implements StudyExecutor {
|
||||
|
||||
@Override
|
||||
public Sdk findSdk(@NotNull final Project project) {
|
||||
return PythonSdkType.findPythonSdk(ModuleManager.getInstance(project).getModules()[0]);
|
||||
}
|
||||
|
||||
@Override
|
||||
public StudyTestRunner getTestRunner(@NotNull final Task task, @NotNull final VirtualFile taskDir) {
|
||||
return new PyStudyTestRunner(task, taskDir);
|
||||
}
|
||||
|
||||
@Override
|
||||
public RunContentExecutor getExecutor(@NotNull final Project project, @NotNull final ProcessHandler handler) {
|
||||
return new RunContentExecutor(project, handler).withFilter(new PythonTracebackFilter(project));
|
||||
}
|
||||
|
||||
@Override
|
||||
public void setCommandLineParameters(@NotNull final GeneralCommandLine cmd,
|
||||
@NotNull final Project project,
|
||||
@NotNull final String filePath,
|
||||
@NotNull final String sdkPath,
|
||||
@NotNull final Task currentTask) {
|
||||
final List<UserTest> userTests = StudyTaskManager.getInstance(project).getUserTests(currentTask);
|
||||
if (!userTests.isEmpty()) {
|
||||
EduPluginConfigurator configurator = EduPluginConfigurator.INSTANCE.forLanguage(currentTask.getLesson().getCourse().getLanguageById());
|
||||
if (configurator != null) {
|
||||
cmd.addParameter(new File(project.getBaseDir().getPath(), "user_tester.py").getPath());
|
||||
cmd.addParameter(sdkPath);
|
||||
cmd.addParameter(filePath);
|
||||
}
|
||||
}
|
||||
else {
|
||||
cmd.addParameter(filePath);
|
||||
}
|
||||
}
|
||||
|
||||
public void showNoSdkNotification(@NotNull final Project project) {
|
||||
final String text = "<html>No Python interpreter configured for the project<br><a href=\"\">Configure interpreter</a></html>";
|
||||
final BalloonBuilder balloonBuilder = JBPopupFactory.getInstance().
|
||||
createHtmlTextBalloonBuilder(text, null,
|
||||
MessageType.WARNING.getPopupBackground(),
|
||||
event -> {
|
||||
if (event.getEventType() == HyperlinkEvent.EventType.ACTIVATED) {
|
||||
ApplicationManager.getApplication()
|
||||
.invokeLater(
|
||||
() -> ShowSettingsUtil.getInstance().showSettingsDialog(project, "Project Interpreter"));
|
||||
}
|
||||
});
|
||||
balloonBuilder.setHideOnLinkClick(true);
|
||||
final Balloon balloon = balloonBuilder.createBalloon();
|
||||
StudyUtils.showCheckPopUp(project, balloon);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user