MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-14 18:05:27 +07:00
Code Issues Packages Projects Releases Wiki Activity

RegExp: remove redundant ObjectUtils.tryCast() call

Browse Source 
GitOrigin-RevId: e1763e01ea638c5864ae2bba18d12453db4730b3
This commit is contained in:
Bas Leijdekkers
2023-06-23 12:55:48 +02:00
committed by intellij-monorepo-bot
parent ab2a1cf48f
commit 71ebca1309
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
RegExpSupport/src/org/intellij/lang/regexp/inspection/RegExpRedundantClassElementInspection.java
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. // Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.intellij.lang.regexp.inspection; package org.intellij.lang.regexp.inspection;
import com.intellij.codeInspection.LocalInspectionTool; import com.intellij.codeInspection.LocalInspectionTool;
@@ -8,14 +8,12 @@ import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.openapi.project.Project; import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement; import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiElementVisitor; import com.intellij.psi.PsiElementVisitor;
import com.intellij.util.ObjectUtils;
import com.intellij.util.containers.ContainerUtil; import com.intellij.util.containers.ContainerUtil;
import org.intellij.lang.regexp.RegExpBundle; import org.intellij.lang.regexp.RegExpBundle;
import org.intellij.lang.regexp.psi.*; import org.intellij.lang.regexp.psi.*;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import static org.intellij.lang.regexp.psi.RegExpSimpleClass.Kind.*; import static org.intellij.lang.regexp.psi.RegExpSimpleClass.Kind.*;
import static org.intellij.lang.regexp.psi.RegExpSimpleClass.Kind.NON_WORD;
public class RegExpRedundantClassElementInspection extends LocalInspectionTool { public class RegExpRedundantClassElementInspection extends LocalInspectionTool {
@Override @Override
@@ -23,17 +21,15 @@ public class RegExpRedundantClassElementInspection extends LocalInspectionTool {
return new RegExpElementVisitor() { return new RegExpElementVisitor() {
@Override @Override
public void visitRegExpClass(RegExpClass regExpClass) { public void visitRegExpClass(RegExpClass regExpClass) {
RegExpClass regExp = ObjectUtils.tryCast(regExpClass, RegExpClass.class); RegExpClassElement[] classElements = regExpClass.getElements();
if (regExp == null) return;
RegExpClassElement[] classElements = regExp.getElements();
boolean containsNonWordCharacterClass = boolean containsNonWordCharacterClass =
ContainerUtil.exists(classElements, RegExpRedundantClassElementInspection::isAnyNonWordCharacter); ContainerUtil.exists(classElements, RegExpRedundantClassElementInspection::isAnyNonWordCharacter);
boolean containsWordCharacterClass = boolean containsWordCharacterClass = ContainerUtil.exists(classElements, RegExpRedundantClassElementInspection::isAnyWordCharacter);
ContainerUtil.exists(classElements, RegExpRedundantClassElementInspection::isAnyWordCharacter);
for (RegExpClassElement element : classElements) { for (RegExpClassElement element : classElements) {
if (containsWordCharacterClass && isAnyDigit(element) || containsNonWordCharacterClass && isAnyNonDigit(element)) { if (containsWordCharacterClass && isAnyDigit(element) || containsNonWordCharacterClass && isAnyNonDigit(element)) {
String elementText = element.getText(); String elementText = element.getText();
holder.registerProblem(element, RegExpBundle.message("inspection.warning.redundant.class.element", elementText), new RemoveRedundantClassElement(elementText)); holder.registerProblem(element, RegExpBundle.message("inspection.warning.redundant.class.element", elementText),
new RemoveRedundantClassElement(elementText));
} }
} }
} }