cleanup — default method, nullability

This commit is contained in:
Vladimir Krivosheev
2016-12-02 16:43:16 +01:00
parent ca9b4b5a34
commit 6e3768ec0d
5 changed files with 32 additions and 55 deletions
@@ -1,5 +1,5 @@
/*
* Copyright 2000-2015 JetBrains s.r.o.
* Copyright 2000-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,7 +29,6 @@ import com.intellij.execution.testframework.sm.runner.SMTestProxy;
import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.PathManager;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.options.SettingsEditor;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Disposer;
import com.intellij.openapi.util.InvalidDataException;
@@ -54,16 +53,6 @@ import java.util.List;
public class TestDiscoveryExtension extends RunConfigurationExtension {
private static final Logger LOG = Logger.getInstance("#" + TestDiscoveryExtension.class.getName());
@Nullable
public SettingsEditor createEditor(@NotNull RunConfigurationBase configuration) {
return null;
}
@Nullable
public String getEditorTitle() {
return null;
}
@NotNull
@Override
public String getSerializationId() {
@@ -117,6 +106,7 @@ public class TestDiscoveryExtension extends RunConfigurationExtension {
}
}
@Override
public void updateJavaParameters(RunConfigurationBase configuration, JavaParameters params, RunnerSettings runnerSettings) {
if (runnerSettings != null || !isApplicableFor(configuration)) {
return;
@@ -147,6 +137,7 @@ public class TestDiscoveryExtension extends RunConfigurationExtension {
throw new WriteExternalException();
}
@Override
protected boolean isApplicableFor(@NotNull final RunConfigurationBase configuration) {
return configuration instanceof JavaTestConfigurationBase && Registry.is("testDiscovery.enabled");
}