MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-04 08:51:02 +07:00
Code Issues Packages Projects Releases Wiki Activity

[extract method] IDEA-315449 fix regression: don't suggest bad signatures when parameter number is not changed

Browse Source 
GitOrigin-RevId: bde662ca1d248af84a69f60713c6ab6aa836d275
This commit is contained in:
Alexandr Suhinin
2023-04-14 17:33:19 +03:00
committed by intellij-monorepo-bot
parent 319841b120
commit 6b3d57627c
4 changed files with 54 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/ChangeSignatureIsIgnored.java Normal file
View File

@@ -0,0 +1,17 @@
class SomeClass {
public boolean test(String filePath) {
return <selection>FileUtilRt.extensionEquals(filePath, "jar") ||
FileUtilRt.extensionEquals(filePath, "zip")</selection>;
}
public void test2(String s){
String parent = s != null ? s.substring(4) : null;
}
}
class FileUtilRt {
static boolean extensionEquals(String filename, String extension) {
return true;
}
}

21
java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/ChangeSignatureIsIgnored_after.java Normal file
View File

@@ -0,0 +1,21 @@
class SomeClass {
public boolean test(String filePath) {
return isaBoolean(filePath);
}
private static boolean isaBoolean(String filePath) {
return FileUtilRt.extensionEquals(filePath, "jar") ||
FileUtilRt.extensionEquals(filePath, "zip");
}
public void test2(String s){
String parent = s != null ? s.substring(4) : null;
}
}
class FileUtilRt {
static boolean extensionEquals(String filename, String extension) {
return true;
}
}