MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-85638 PY-85893 Use soft-key soft-value map for TypeEvalContext caches

Browse Source 
This prevents the caches from blowing up in size when analyzing a lot of files in a row

The most obvious example is running `Analyze code` on the whole project. Previously, all PSI elements from all files would pollute the cache, potentially consuming multiple Gb of memory. See PyDjangoSourcesPerformanceTest as an example. It used to require 16 Gb of heap, and it would still sometimes fail with OOM. Now, it runs smoothly with 2Gb of heap

GitOrigin-RevId: f9854f8abdd7086414df8f610b0f2d611ca0d455
This commit is contained in:
evgeny.bovykin
2025-12-09 17:41:26 +00:00
committed by intellij-monorepo-bot
parent f499dde1ce
commit 6a772de5d5
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/python-psi-api/src/com/jetbrains/python/psi/types/TypeEvalContext.java
+18 -4
View File
@@ -27,6 +27,7 @@ import org.jetbrains.annotations.Nullable;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentMap;
import java.util.function.Function;
@@ -52,10 +53,23 @@ public sealed class TypeEvalContext {
private final ThreadLocal<ProcessingContext> myProcessingContext = ThreadLocal.withInitial(ProcessingContext::new);
protected final Map<PyTypedElement, PyType> myEvaluated = CollectionFactory.createConcurrentSoftValueMap();
protected final Map<PyTypedElement, PyType> myExternalEvaluated = CollectionFactory.createConcurrentSoftValueMap();
protected final Map<PyCallable, PyType> myEvaluatedReturn = CollectionFactory.createConcurrentSoftValueMap();
protected final Map<Pair<PyExpression, Object>, PyType> contextTypeCache = CollectionFactory.createConcurrentSoftValueMap();
protected final Map<PyTypedElement, PyType> myEvaluated = getConcurrentMapForCaching();
protected final Map<PyTypedElement, PyType> myExternalEvaluated = getConcurrentMapForCaching();
protected final Map<PyCallable, PyType> myEvaluatedReturn = getConcurrentMapForCaching();
protected final Map<Pair<PyExpression, Object>, PyType> contextTypeCache = getConcurrentMapForCaching();
private static <T> @NotNull ConcurrentMap<@NotNull T, @NotNull PyType> getConcurrentMapForCaching() {
if (Registry.is("python.typing.soft.keys.type.eval.context")) {
// In the current implementation, this value is only used to initialize the map and is basically ignored
// Just in case, set it to a reasonable value
// `Runtime.availableProcessors` shouldn't be called here, as that is a potentially expensive operation
int concurrencyLevel = 4;
return CollectionFactory.createConcurrentSoftKeySoftValueMap(10, 0.75f, concurrencyLevel);
}
else {
return CollectionFactory.createConcurrentSoftValueMap();
}
}
protected static final Logger logger = Logger.getInstance(TypeEvalContext.class);