[lombok]: #2629 SneakyThrows permits missing 'catch' blocks in checked-exception-throwing try-with-resource blocks within lambdas

GitOrigin-RevId: 44f1a479a6c5a3152218bd2424216d76e52ce04d

plugins/lombok/README.md

@@ -44,7 +44,7 @@ Many features of the plugin (including warnings) could be disabled through per-p
 - [**@juriad** Adam Juraszek](https://github.com/juriad)
 - [**@kuil09** Hwang, Geon Gu](https://github.com/kuil09)
 - [**@krzyk** Krzysztof Krasoń](https://github.com/krzyk)
-- [**@Lekanich** Aleksandr Zhelezniak](https://github.com/Lekanich)
+- [**@Lekanich** Oleksandr Zhelezniak](https://github.com/Lekanich)
 - [**@mg6maciej** Maciej Górski](https://github.com/mg6maciej)
 - [**@mlueders** Mike Lueders](https://github.com/mlueders)
 - [**@RohanTalip** Rohan Talip](https://github.com/RohanTalip)

plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/handler/SneakyThrowsExceptionHandler.java

@@ -22,20 +22,10 @@ public final class SneakyThrowsExceptionHandler extends CustomExceptionHandler {
 
   @Override
   public boolean isHandled(@Nullable PsiElement element, @NotNull PsiClassType exceptionType, PsiElement topElement) {
-    PsiElement parent = PsiTreeUtil.getParentOfType(element, PsiLambdaExpression.class, PsiTryStatement.class, PsiMethod.class);
-    if (parent instanceof PsiLambdaExpression) {
-      // lambda it's another scope, @SneakyThrows annotation can't neglect exceptions in lambda only on method, constructor
-      return false;
-    }
-    if (parent instanceof PsiTryStatement && isHandledByTryCatch(exceptionType, (PsiTryStatement)parent)) {
-      // that exception MAY be already handled by regular try-catch statement
+    if (isHandledByParent(element, exceptionType)) {
       return false;
     }
 
-    if (topElement instanceof PsiTryStatement && isHandledByTryCatch(exceptionType, (PsiTryStatement)topElement)) {
-      // that exception MAY be already handled by regular try-catch statement (don't forget about nested try-catch)
-      return false;
-    }
     if (!(topElement instanceof PsiCodeBlock)) {
       final PsiMethod psiMethod = PsiTreeUtil.getParentOfType(element, PsiMethod.class);
       if (psiMethod != null) {
@@ -49,6 +39,24 @@ public final class SneakyThrowsExceptionHandler extends CustomExceptionHandler {
     return false;
   }
 
+  private static boolean isHandledByParent(@Nullable PsiElement element, @NotNull PsiClassType exceptionType) {
+    PsiElement parent = PsiTreeUtil.getParentOfType(element, PsiLambdaExpression.class, PsiTryStatement.class, PsiMethod.class);
+    if(parent == null) {
+      return false;
+    } else if (parent instanceof PsiMethod) {
+      // we out of the scope of the method, so the exception wasn't handled inside the method
+      return false;
+    } else if (parent instanceof PsiLambdaExpression) {
+      // lambda it's another scope, @SneakyThrows annotation can't neglect exceptions in lambda only on method, constructor
+      return true;
+    } else if (parent instanceof PsiTryStatement && isHandledByTryCatch(exceptionType, (PsiTryStatement) parent)) {
+      // that exception MAY be already handled by regular try-catch statement
+      return true;
+    }
+    // in case if the try block inside the lambda or inside another try-catch. GitHub issue: 1170
+    return isHandledByParent(parent, exceptionType);
+  }
+
   private static boolean isConstructorMethodWithExceptionInSiblingConstructorCall(@NotNull PsiMethod containingMethod,
                                                                                   @NotNull PsiClassType exceptionTypes) {
     final PsiMethodCallExpression thisOrSuperCallInConstructor = JavaPsiConstructorUtil.findThisOrSuperCallInConstructor(containingMethod);

plugins/lombok/src/test/java/de/plushnikov/intellij/plugin/highlights/SneakyThrowsHighlightTest.java

@@ -30,4 +30,8 @@ public class SneakyThrowsHighlightTest extends AbstractLombokHighlightsTest {
   public void testSneakThrowsDoesntCatchExceptionFromThisConstructor() {
     doTest();
   }
+
+  public void testSneakyThrowsTryInsideLambda() {
+    doTest();
+  }
 }

plugins/lombok/testData/highlights/sneakyThrows/SneakyThrowsTryInsideLambda.java

@@ -0,0 +1,37 @@
+import lombok.SneakyThrows;
+import java.io.Reader;
+import java.io.FileReader;
+
+public class SneakyThrowsTryInsideLambda {
+  @SneakyThrows
+  public static void m() {
+    Runnable r = () -> {
+      try (Reader reader = new <error descr="Unhandled exception: java.io.FileNotFoundException">FileReader</error>("")) {}
+    };
+  }
+
+  // everything is ok here
+  @SneakyThrows
+  void m2() {
+    try (Reader reader = new FileReader("")) {}
+  }
+
+  @SneakyThrows
+  public static void m3() {
+    try {
+      try (Reader reader = new FileReader("")) {
+      }
+    } catch (java.lang.NullPointerException e) {
+    }
+  }
+
+  @SneakyThrows
+  public static void m4() {
+    class A {
+      public void m() {
+        try (Reader reader = new <error descr="Unhandled exception: java.io.FileNotFoundException">FileReader</error>("")) {
+        }
+      }
+    }
+  }
+}