This commit is contained in:
Alexey Kudravtsev
2011-04-18 17:06:14 +04:00
parent 5e3e99fd63
commit 5a06b76548
@@ -181,9 +181,15 @@ public class MethodReturnTypeFix extends LocalQuickFixAndIntentionActionOnPsiEle
try {
final ConvertReturnStatementsVisitor visitor = new ConvertReturnStatementsVisitor(factory, method, myTargetType);
final ControlFlow controlFlow = HighlightControlFlowUtil.getControlFlowNoConstantEvaluate(method.getBody());
ControlFlow controlFlow;
try {
controlFlow = HighlightControlFlowUtil.getControlFlowNoConstantEvaluate(method.getBody());
}
catch (AnalysisCanceledException e) {
controlFlow = null; //must be an error
}
PsiReturnStatement returnStatement;
if (ControlFlowUtil.processReturns(controlFlow, visitor)) {
if (controlFlow != null && ControlFlowUtil.processReturns(controlFlow, visitor)) {
// extra return statement not needed
// get latest modified return statement and select...
returnStatement = visitor.getLatestReturn();
@@ -193,10 +199,6 @@ public class MethodReturnTypeFix extends LocalQuickFixAndIntentionActionOnPsiEle
}
mySelector.accept(returnStatement, method);
}
catch (AnalysisCanceledException e) {
LOG.error(e);
return;
}
catch (IncorrectOperationException e) {
LOG.error(e);
}