MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-inspection] IJ-CR-128589 IDEA-349655 Improvements for logging inspections. new LogStatementNotGuardedByLogCondition

Browse Source 
- delete custom settings

GitOrigin-RevId: dc3625006922b3db74c6f478a3b1ac8bf5e5ddad
This commit is contained in:
Mikhail Pyltsin
2024-03-22 14:28:29 +00:00
committed by intellij-monorepo-bot
parent 96408c28cf
commit 59f94d7232
6 changed files with 10 additions and 354 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jvm/jvm-analysis-java-tests/testSrc/com/intellij/codeInspection/tests/java/logging/JavaLoggingStatementNotGuardedByLogConditionInspectionTest.kt
-149
View File
@@ -44,18 +44,6 @@ class JavaLoggingStatementNotGuardedByLogConditionInspectionTest : LoggingStatem
""".trimIndent())
}
fun `test custom logger`() {
myFixture.testHighlighting(JvmLanguage.JAVA, """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
<warning descr="Logging call not guarded by log condition">LOG.fine("test" + arg)</warning>;
}
}
""".trimIndent())
}
fun `test skip according level for slf4j`() {
myFixture.testHighlighting(JvmLanguage.JAVA, """
import org.slf4j.Logger;
@@ -199,19 +187,6 @@ class JavaLoggingStatementNotGuardedByLogConditionInspectionTest : LoggingStatem
""".trimIndent())
}
fun `test skip with several log calls for custom logger`() {
myFixture.testHighlighting(JvmLanguage.JAVA, """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
<warning descr="Logging call not guarded by log condition">LOG.fine("test" + arg)</warning>;
LOG.fine("test" + arg);
}
}
""".trimIndent())
}
fun `test lambda`() {
myFixture.testHighlighting(JvmLanguage.JAVA, """
import org.apache.logging.log4j.*;
@@ -288,66 +263,6 @@ class JavaLoggingStatementNotGuardedByLogConditionInspectionTest : LoggingStatem
)
}
fun `test fix simple custom`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
LOG.<caret>fine("test" + arg);
}
}
""".trimIndent(),
after = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
if (LOG.isLoggable(Level.FINE)) {
LOG.fine("test" + arg);
}
}
}
""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.log.statement.not.guarded.log.fix.family.name")
)
}
fun `test fix simple nested custom`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
if(true){
LOG.<caret>fine("test" + arg);
}
}
}
""".trimIndent(),
after = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
if(true){
if (LOG.isLoggable(Level.FINE)) {
LOG.fine("test" + arg);
}
}
}
}
""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.log.statement.not.guarded.log.fix.family.name")
)
}
fun `test fix several similar slf4j`() {
myFixture.testQuickFix(
testPreview = true,
@@ -382,38 +297,6 @@ class JavaLoggingStatementNotGuardedByLogConditionInspectionTest : LoggingStatem
)
}
fun `test fix several similar custom`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
LOG<caret>.fine("test1" + arg);
LOG.fine("test2" + arg);
LOG.fine("test3" + arg);
}
}
""".trimIndent(),
after = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
if (LOG.isLoggable(Level.FINE)) {
LOG.fine("test1" + arg);
LOG.fine("test2" + arg);
LOG.fine("test3" + arg);
}
}
}
""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.log.statement.not.guarded.log.fix.family.name")
)
}
fun `test fix several different slf4j`() {
myFixture.testQuickFix(
testPreview = true,
@@ -447,36 +330,4 @@ class JavaLoggingStatementNotGuardedByLogConditionInspectionTest : LoggingStatem
hint = JvmAnalysisBundle.message("jvm.inspection.log.statement.not.guarded.log.fix.family.name")
)
}
fun `test fix several different custom`() {
myFixture.testQuickFix(
testPreview = true,
lang = JvmLanguage.JAVA,
before = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
LOG<caret>.fine("test1" + arg);
LOG.fine("test2" + arg);
LOG.finer("test3" + arg);
}
}
""".trimIndent(),
after = """
import java.util.logging.*;
class X {
static final Logger LOG = Logger.getLogger("");
void n(String arg) {
if (LOG.isLoggable(Level.FINE)) {
LOG.fine("test1" + arg);
LOG.fine("test2" + arg);
}
LOG.finer("test3" + arg);
}
}
""".trimIndent(),
hint = JvmAnalysisBundle.message("jvm.inspection.log.statement.not.guarded.log.fix.family.name")
)
}
}