RedundantCollectionOperation: remove by index and contains before add/remove

IDEA-182694 Inefficient uses of Collection/List.remove

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterContainsRemove.java

@@ -0,0 +1,9 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+      /*contains!!!*/
+      list.remove(/*remove!!!*/key);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterContainsRemoveAnd.java

@@ -0,0 +1,10 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(key != null) {
+      list.remove(key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterContainsRemoveAndAnd.java

@@ -0,0 +1,11 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(key !=/*nullcheck*/ null && !key./*check*/isEmpty()  /*and*/ /*key*/ //line comment
+            ) {
+      list.remove(key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterRemoveByIndexSimple.java

@@ -0,0 +1,8 @@
+// "Use removal by object" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    list.remove(key);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterRemoveByIndexVar.java

@@ -0,0 +1,8 @@
+// "Use removal by object" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+      list.remove(key);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeContainsRemove.java

@@ -0,0 +1,10 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(list.co<caret>ntains(/*contains!!!*/key)) {
+      list.remove(/*remove!!!*/key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeContainsRemoveAnd.java

@@ -0,0 +1,10 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(key != null && list.co<caret>ntains(key)) {
+      list.remove(key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeContainsRemoveAndAnd.java

@@ -0,0 +1,11 @@
+// "Remove the 'contains' check" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(key !=/*nullcheck*/ null && !key./*check*/isEmpty() && /*and*/ list.co<caret>ntains(/*key*/key//line comment
+    )) {
+      list.remove(key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeContainsRemoveAndFirst.java

@@ -0,0 +1,10 @@
+// "Remove the 'contains' check" "false"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    if(list.co<caret>ntains(key) && key != null) {
+      list.remove(key);
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeRemoveByIndexSimple.java

@@ -0,0 +1,8 @@
+// "Use removal by object" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    list.r<caret>emove(list.indexOf(key));
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeRemoveByIndexUsed.java

@@ -0,0 +1,9 @@
+// "Use removal by object" "false"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    int idx = list.indexOf(key);
+    String x = list.r<caret>emove(idx);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeRemoveByIndexVar.java

@@ -0,0 +1,9 @@
+// "Use removal by object" "true"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, String key) {
+    int idx = list.indexOf(key);
+    list.r<caret>emove(idx);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeRemoveByIndexWrongQualifier.java

@@ -0,0 +1,9 @@
+// "Use removal by object" "false"
+import java.util.List;
+
+class Test {
+  void test(List<String> list, List<String> list2, String key) {
+    int idx = list.indexOf(key);
+    list2.r<caret>emove(idx);
+  }
+}