MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-10 13:17:09 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-385449 [java-inspections] ExpressionUtils.isEvaluatedAtCompileTime may cause stackoverflow

Browse Source 
GitOrigin-RevId: b54864f2e62a2d38f75f4b7d86e006b779ce5cd5
This commit is contained in:
Tagir Valeev
2026-02-03 14:08:29 +00:00
committed by intellij-monorepo-bot
parent cfdf5adc9a
commit 466473c654
2 changed files with 50 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/siyeh/ig/psiutils/ExpressionUtils.java
+30 -10
View File
@@ -213,19 +213,25 @@ public final class ExpressionUtils {
@Contract("null -> false")
public static boolean isEvaluatedAtCompileTime(@Nullable PsiExpression expression) {
return isEvaluatedAtCompileTime(expression, ContainerUtil.newHashSet());
}
private static boolean isEvaluatedAtCompileTime(@Nullable PsiExpression expression,
@NotNull Set<PsiVariable> visited) {
if (expression == null) return false;
if (expression instanceof PsiLiteralExpression) {
return true;
}
if (expression instanceof PsiPolyadicExpression polyadicExpression) {
for (PsiExpression operand : polyadicExpression.getOperands()) {
if (!isEvaluatedAtCompileTime(operand)) {
if (!isEvaluatedAtCompileTime(operand, visited)) {
return false;
}
}
return true;
}
if (expression instanceof PsiPrefixExpression prefixExpression) {
return isEvaluatedAtCompileTime(prefixExpression.getOperand());
return isEvaluatedAtCompileTime(prefixExpression.getOperand(), visited);
}
if (expression instanceof PsiReferenceExpression referenceExpression) {
final PsiElement qualifier = referenceExpression.getQualifier();
@@ -234,21 +240,35 @@ public final class ExpressionUtils {
}
final PsiElement element = referenceExpression.resolve();
if (element instanceof PsiVariable variable) {
return !PsiTreeUtil.isAncestor(variable, expression, true)
&& variable.hasModifierProperty(PsiModifier.FINAL)
&& isEvaluatedAtCompileTime(PsiFieldImpl.getDetachedInitializer(variable));
if (visited.contains(variable)) {
// cyclic reference detected; not a compile-time evaluatable expression
return false;
}
if (PsiTreeUtil.isAncestor(variable, expression, true)) {
return false;
}
if (!variable.hasModifierProperty(PsiModifier.FINAL)) {
return false;
}
visited.add(variable);
try {
return isEvaluatedAtCompileTime(PsiFieldImpl.getDetachedInitializer(variable), visited);
}
finally {
visited.remove(variable);
}
}
}
if (expression instanceof PsiParenthesizedExpression parenthesizedExpression) {
return isEvaluatedAtCompileTime(parenthesizedExpression.getExpression());
return isEvaluatedAtCompileTime(parenthesizedExpression.getExpression(), visited);
}
if (expression instanceof PsiConditionalExpression conditionalExpression) {
return isEvaluatedAtCompileTime(conditionalExpression.getCondition()) &&
isEvaluatedAtCompileTime(conditionalExpression.getThenExpression()) &&
isEvaluatedAtCompileTime(conditionalExpression.getElseExpression());
return isEvaluatedAtCompileTime(conditionalExpression.getCondition(), visited) &&
isEvaluatedAtCompileTime(conditionalExpression.getThenExpression(), visited) &&
isEvaluatedAtCompileTime(conditionalExpression.getElseExpression(), visited);
}
if (expression instanceof PsiTypeCastExpression typeCastExpression) {
return hasStringType(typeCastExpression) && isEvaluatedAtCompileTime(typeCastExpression.getOperand());
return hasStringType(typeCastExpression) && isEvaluatedAtCompileTime(typeCastExpression.getOperand(), visited);
}
return false;
}