MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-08-26 15:27:45 +07:00
Code Issues Packages Projects Releases Wiki Activity

Optional compared with null: do not warn when subsequent isPresent check is found

Browse Source 
IDEA-187578  Inspection to detect when Optional is compared with null
This commit is contained in:
Tagir Valeev
2018-03-09 19:30:59 +07:00
parent 273862e0bb
commit 350eba5000
3 changed files with 76 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/optionalNull/afterOptionalComparison.java
+21
View File
@@ -17,4 +17,25 @@ public class Test {
}
}
void test3 (Optional<String> opt) {
// this case is ignored
if(opt == null || !opt.isPresent()) {
System.out.println("null or absent");
}
}
void test4 (Optional<String> opt) {
// this case is ignored as well
if(opt != null && opt.isPresent()) {
System.out.println("present");
}
}
void test5 (Optional<String> opt, Optional<String> opt2) {
// warn: different optionals used
if(opt.isPresent() && opt2.isPresent()) {
System.out.println("present");
}
}
}
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/optionalNull/beforeOptionalComparison.java
+21
View File
@@ -16,4 +16,25 @@ public class Test {
}
}
void test3 (Optional<String> opt) {
// this case is ignored
if(opt == null || !opt.isPresent()) {
System.out.println("null or absent");
}
}
void test4 (Optional<String> opt) {
// this case is ignored as well
if(opt != null && opt.isPresent()) {
System.out.println("present");
}
}
void test5 (Optional<String> opt, Optional<String> opt2) {
// warn: different optionals used
if(opt != null && opt2.isPresent()) {
System.out.println("present");
}
}
}