MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-06 03:21:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

EA-143721 EA-143411 EA-141118 Remove useless exceptions reporting

Browse Source 
These exceptions are useless without additional information from user. So we should log them and discuss user's particular use case in issue tracker

GitOrigin-RevId: 5d1ae8e03fd88f51fde1e89d35b7b563272ba675
This commit is contained in:
Elizaveta Shashkova
2019-10-30 19:35:22 +03:00
committed by intellij-monorepo-bot
parent 2667c90266
commit 3219a4d2f8
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/pydevSrc/com/jetbrains/python/debugger/pydev/AbstractCommand.java
View File

@@ -1,9 +1,12 @@
package com.jetbrains.python.debugger.pydev;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.diagnostic.Logger;
import com.jetbrains.python.debugger.PyDebuggerException;
import org.jetbrains.annotations.NotNull;
import java.lang.invoke.MethodHandles;
public abstract class AbstractCommand<T> {
@@ -77,6 +80,7 @@ public abstract class AbstractCommand<T> {
private final ResponseProcessor<T> myResponseProcessor;
public static final Logger LOG = Logger.getInstance(MethodHandles.lookup().lookupClass());
protected AbstractCommand(@NotNull final RemoteDebugger debugger, final int commandCode) {
myDebugger = debugger;
@@ -135,15 +139,18 @@ public abstract class AbstractCommand<T> {
if (processor == null && !isResponseExpected()) return;
if (!frameSent) {
throw new PyDebuggerException("Couldn't send frame " + myCommandCode);
LOG.error("Couldn't send frame " + myCommandCode);
return;
}
frame = myDebugger.waitForResponse(sequence, getResponseTimeout());
if (frame == null) {
String errorMessage = "Timeout waiting for response on " + myCommandCode;
if (!myDebugger.isConnected()) {
throw new PyDebuggerException("No connection (command: " + myCommandCode + " )");
errorMessage = "No connection (command: " + myCommandCode + " )";
}
throw new PyDebuggerException("Timeout waiting for response on " + myCommandCode);
LOG.error(errorMessage);
return;
}
if (processor != null) {
processor.processResponse(frame);