[uast-inspection] IDEA-326308

Add an option to report only unsafe strings from the "Non-safe string is passed to safe method" GitOrigin-RevId: 5f889b3cc5aaac9f98a6a335da600b0759f56c5c
2026-10-02 07:47:25 +07:00 · 2023-07-25 19:09:29 +00:00
parent cb0fbf4052
commit 2d060a17a9
4 changed files with 178 additions and 4 deletions
@@ -0,0 +1,131 @@
+package org.checkerframework.checker.tainting.qual;
+
+public class Simple {
+  
+    void simple() {
+      String s = source();
+      sink(<warning descr="Unsafe string is used as safe parameter">s</warning>);
+    }
+  
+    void alias() {
+      String s1 = source();
+      String s = s1;
+      sink(<warning descr="Unsafe string is used as safe parameter">s</warning>);
+    }
+  
+    void unknown() {
+      String s = foo();
+      sink(s);
+    }
+  
+    void literalOnly() {
+      String s = null;
+      s = "safe";
+      sink(s);
+    }
+  
+    void safeCall() {
+      String s = "safe";
+      s = safe();
+      sink(s);
+    }
+  
+    void sourceCallToSink() {
+      sink(<warning descr="Unsafe string is used as safe parameter">source()</warning>);
+    }
+  
+    void safeCallToSink() {
+      sink(safe());
+    }
+  
+    void sourceFromClass() {
+      String s = (new WithSourceParent()).source();
+      sink(<warning descr="Unsafe string is used as safe parameter">s</warning>);
+    }
+
+    void sourceFromChildClass() {
+      WithSourceChild child = new WithSourceChild();
+      String s = child.source();
+      sink(<warning descr="Unsafe string is used as safe parameter">s</warning>);
+    }
+
+    void withParenthesis() {
+      String s1 = (source());
+      s1 = (foo());
+      String s = (s1);
+      sink(<warning descr="Unsafe string is used as safe parameter">(s)</warning>);
+    }
+  
+    @Untainted String unsafeReturn() {
+      return <warning descr="Unsafe string is returned from safe method">source()</warning>;
+    }
+  
+    void sourceToSafeString() {
+      @Untainted String s = "safe";
+      s = <warning descr="Unsafe string is assigned to safe variable">source()</warning>;
+    }
+
+    void unsafeConcat() {
+      @Tainted String s = source();
+      String s1 = "safe";
+      String s2 = "safe2";
+      sink(<warning descr="Unsafe string is used as safe parameter">s1 + s + s2</warning>);
+    }
+
+    void unsafeTernary(boolean b) {
+      @Tainted String s = source();
+      sink(<warning descr="Unsafe string is used as safe parameter">b ? s : null</warning>);
+    }
+  
+    void fieldFromGetter() {
+      String s = getField();
+      sink(s);
+    }
+    
+    void assignToSafeLocalVar() {
+      String s1 = getField();
+      @Untainted String safe = s1;
+      String s2 = source();
+      safe = <warning descr="Unsafe string is assigned to safe variable">s2</warning>;
+    }
+
+    private final String field = foo();
+
+    public String getField() {
+      return field;
+    }
+
+    String callSource() {
+      return source();
+    }
+
+    String foo() {
+      return "some";
+    }
+
+    @Untainted
+    String safe() {
+      return "safe";
+    }
+
+    @Tainted
+    String source() {
+      return "tainted";
+    }
+
+    void sink(@Untainted String s1) {}
+
+    class WithSourceParent {
+      @Tainted
+      String source() {
+        return "tainted";
+      }
+    }
+
+    class WithSourceChild extends WithSourceParent {
+      @Override
+      String source() {
+        return super.source();
+      }
+    }
+}