IDEA-231237 Loop-to-stream conversion produces incorrect code if pattern variable is introduced

Also: pattern variable can be deleted via simple .delete()

GitOrigin-RevId: d3523f64d86de28d90b82d7bd98c1fd70567652d

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/afterPattern.java

@@ -0,0 +1,10 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+import java.util.stream.Collectors;
+
+class X {
+  void test(List<Object> list) {
+    List<String> result = list.stream().filter(o -> o instanceof String).map(o -> (String) o).collect(Collectors.toList());
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/afterPatternOriginalUsed.java

@@ -0,0 +1,12 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+import java.util.stream.Collectors;
+
+class X {
+  void test(List<Object> list) {
+    List<Object> result = list.stream().filter(o -> getObject(o) instanceof String s && !s.isEmpty()).collect(Collectors.toList());
+  }
+  
+  native Object getObject(Object obj);
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/afterPatternUsed.java

@@ -0,0 +1,10 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+import java.util.stream.Collectors;
+
+class X {
+  void test(List<Object> list) {
+    List<String> result = list.stream().filter(o -> o instanceof String s && !s.isEmpty()).map(o -> (String) o).collect(Collectors.toList());
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/beforePattern.java

@@ -0,0 +1,14 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+
+class X {
+  void test(List<Object> list) {
+    List<String> result = new ArrayList<>();
+    f<caret>or (Object o : list) {
+      if (o instanceof String s) {
+        result.add(s);
+      }
+    }
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/beforePatternOriginalUsed.java

@@ -0,0 +1,16 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+
+class X {
+  void test(List<Object> list) {
+    List<Object> result = new ArrayList<>();
+    f<caret>or (Object o : list) {
+      if (getObject(o) instanceof String s && !s.isEmpty()) {
+        result.add(o);
+      }
+    }
+  }
+  
+  native Object getObject(Object obj);
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/streamApiMigration/java14/beforePatternUsed.java

@@ -0,0 +1,14 @@
+// "Fix all 'Loop can be collapsed with Stream API' problems in file" "true"
+import java.util.List;
+import java.util.ArrayList;
+
+class X {
+  void test(List<Object> list) {
+    List<String> result = new ArrayList<>();
+    f<caret>or (Object o : list) {
+      if (o instanceof String s && !s.isEmpty()) {
+        result.add(s);
+      }
+    }
+  }
+}