MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-01 18:58:31 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix false positive on method called from subclass in the same file (IDEA-269128)

Browse Source 
for "Declaration access can be weaker" global inspection

GitOrigin-RevId: 2d89a3eeb9f2bc8ffe13e1d57dfff94169a616c6
This commit is contained in:
Bas Leijdekkers
2022-04-16 00:38:16 +02:00
committed by intellij-monorepo-bot
parent 8c3598f988
commit 213c72182e
4 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
java/java-analysis-impl/src/com/intellij/codeInspection/reference/RefJavaUtilImpl.java
View File

@@ -1,10 +1,10 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInspection.reference;
import com.intellij.codeInsight.daemon.impl.analysis.GenericsHighlightUtil;
import com.intellij.java.analysis.JavaAnalysisBundle;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.impl.light.LightElement;
import com.intellij.psi.impl.light.LightRecordCanonicalConstructor;
@@ -490,20 +490,17 @@ public class RefJavaUtilImpl extends RefJavaUtil {
refMethod.updateParameterValues(argumentList, psiResolved);
}
final UExpression uExpression = call.getReceiver();
if (uExpression != null) {
final PsiType usedType = uExpression.getExpressionType();
if (usedType != null) {
UClass containingClass = UDeclarationKt.getContainingDeclaration(uMethod, UClass.class);
final String fqName;
if (containingClass != null) {
fqName = containingClass.getQualifiedName();
if (fqName != null) {
final PsiClassType methodOwnerType = JavaPsiFacade.getElementFactory(psiResolved.getProject())
.createTypeByFQClassName(fqName, GlobalSearchScope.allScope(psiResolved.getProject()));
if (!usedType.equals(methodOwnerType)) {
refMethod.setCalledOnSubClass(true);
}
final PsiType usedType = call.getReceiverType();
if (usedType != null) {
UClass containingClass = UDeclarationKt.getContainingDeclaration(uMethod, UClass.class);
if (containingClass != null) {
final String fqName = containingClass.getQualifiedName();
if (fqName != null) {
final Project project = psiResolved.getProject();
final PsiClassType methodOwnerType = JavaPsiFacade.getElementFactory(project)
.createTypeByFQClassName(fqName, GlobalSearchScope.allScope(project));
if (!usedType.equals(methodOwnerType)) {
refMethod.setCalledOnSubClass(true);
}
}
}