MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-13 15:52:01 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-inspections] IDEA-337706 Support conversion System.out to log calls

Browse Source 
- support custom names for Lombok
- loggerTypeName now always returns full qualified class of logger
- `com.intellij.lang.logging.JvmLogger.Companion.getAllNamedContainingClasses` return List for compatibility with Java

GitOrigin-RevId: c07ed5bdb2f684fdc7be864d8cd7192d3ea0245c
This commit is contained in:
Mikhail Pyltsin
2024-04-02 17:57:35 +02:00
committed by intellij-monorepo-bot
parent e84bc31482
commit 206d995dcd
6 changed files with 29 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/logging/JvmLoggerAnnotationDelegate.kt
View File

@@ -10,19 +10,20 @@ import com.intellij.psi.PsiAnnotation
import com.intellij.psi.PsiClass
import com.intellij.psi.PsiElement
import com.intellij.psi.codeStyle.JavaCodeStyleManager
import de.plushnikov.intellij.plugin.processor.clazz.log.AbstractLogProcessor
import de.plushnikov.intellij.plugin.util.LombokLibraryUtil
/**
* Represents a delegate implementation of the JvmLogger interface that is used to insert loggers which are [PsiAnnotation].
* Use it to handle with Lombok loggers
* @param fieldLoggerName the fully qualified name of the logger's type.
* @param loggerTypeName the fully qualified name of annotation used to generate logger
* @param loggerTypeName the fully qualified name of the logger's type.
* @param annotationTypeName the fully qualified name of annotation used to generate logger
* @param priority the priority of the logger.
*/
class JvmLoggerAnnotationDelegate(
private val fieldLoggerName: String,
override val id: String,
override val loggerTypeName: String,
override val id: String,
private val annotationTypeName: String,
override val priority: Int
) : JvmLogger {
override fun insertLoggerAtClass(project: Project, clazz: PsiClass, logger: PsiElement): PsiElement? {
@@ -33,18 +34,22 @@ class JvmLoggerAnnotationDelegate(
override fun isAvailable(project: Project?): Boolean {
return project != null &&
JavaPsiFacade.getInstance(project).findClass(fieldLoggerName, ProjectContainingLibrariesScope.getScope(project)) != null
JavaPsiFacade.getInstance(project).findClass(loggerTypeName, ProjectContainingLibrariesScope.getScope(project)) != null
&& LombokLibraryUtil.hasLombokLibrary(project)
}
override fun isAvailable(module: Module?): Boolean {
return module != null && JavaLibraryUtil.hasLibraryClass(module, fieldLoggerName) && LombokLibraryUtil.hasLombokClasses(module)
return module != null && JavaLibraryUtil.hasLibraryClass(module, loggerTypeName) && LombokLibraryUtil.hasLombokClasses(module)
}
override fun isPossibleToPlaceLoggerAtClass(clazz: PsiClass): Boolean = clazz.hasAnnotation(loggerTypeName).not()
override fun isPossibleToPlaceLoggerAtClass(clazz: PsiClass): Boolean = clazz.hasAnnotation(annotationTypeName).not()
override fun createLogger(project: Project, clazz: PsiClass): PsiAnnotation {
val factory = JavaPsiFacade.getElementFactory(project)
return factory.createAnnotationFromText("@$loggerTypeName", clazz)
return factory.createAnnotationFromText("@$annotationTypeName", clazz)
}
override fun getLogFieldName(clazz: PsiClass): String {
return AbstractLogProcessor.getLoggerName(clazz)
}
}