MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

RedundantCollectionOperation: warn on if(map.containsKey(x)) map.remove(x)

Browse Source 
Review ID: IDEA-CR-28150
This commit is contained in:
Tagir Valeev
2018-01-22 13:39:09 +07:00
parent c95dca14e9
commit 1a40a9f877
4 changed files with 37 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/afterContainsKeyRemove.java
+9
View File
@@ -0,0 +1,9 @@
// "Remove the 'containsKey' check" "true"
import java.util.Map;
class Test {
void test(Map<String, Integer> map, String key) {
/*contains!!!*/
map.remove(/*remove!!!*/key);
}
}
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCollectionOperation/beforeContainsKeyRemove.java
+10
View File
@@ -0,0 +1,10 @@
// "Remove the 'containsKey' check" "true"
import java.util.Map;
class Test {
void test(Map<String, Integer> map, String key) {
if(map.co<caret>ntainsKey(/*contains!!!*/key)) {
map.remove(/*remove!!!*/key);
}
}
}