MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 22:51:17 +07:00
Code Issues Packages Projects Releases Wiki Activity

[freeze][dataflow from here] IDEA-268322 Freeze when Analyze Data Flow from Here

Browse Source 
This patch restores the blocking read computation in JavaOverridingMethodsSearcher because the "nonBlocking()" call changes semantics of JavaOverridingMethodSearcher. Nonblocking made it be interrupted by write actions and everything became invalid in the middle of a computation, which might have affected the clients.

The analyze from/to here panel should be rewritten to the async model with the help from AsyncTreeModel.

GitOrigin-RevId: ed6864ba098724487f9836ecf880bbed60da0545
This commit is contained in:
Nikita Eshkeev
2021-05-25 14:14:55 +03:00
committed by intellij-monorepo-bot
parent fbd9397bf1
commit 17d84a1681
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/java-indexing-impl/src/com/intellij/psi/impl/search/JavaOverridingMethodsSearcher.java
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.intellij.psi.impl.search;
import com.intellij.ide.highlighter.JavaFileType;
@@ -113,7 +113,7 @@ public class JavaOverridingMethodsSearcher implements QueryExecutor<PsiMethod, O
assert containingClass != null;
Collection<PsiMethod> result = new HashSet<>();
Processor<PsiClass> inheritorsProcessor = inheritor -> {
PsiMethod found = ReadAction.nonBlocking(() -> findOverridingMethod(inheritor, method, containingClass)).executeSynchronously();
PsiMethod found = ReadAction.compute(() -> findOverridingMethod(inheritor, method, containingClass));
if (found != null) {
synchronized (result) {
result.add(found);