MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-01 10:48:09 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java: handle @Repeatable annotations better in “Unused declaration” inspection

Browse Source 
GitOrigin-RevId: 677f2c52ac069497147398dce1b42709e78ff445
This commit is contained in:
Bas Leijdekkers
2024-05-09 12:26:07 +02:00
committed by intellij-monorepo-bot
parent 33881c73d1
commit 153827d95f
3 changed files with 23 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
java/java-analysis-impl/src/com/intellij/codeInspection/reference/RefJavaUtilImpl.java
View File

@@ -75,10 +75,32 @@ public final class RefJavaUtilImpl extends RefJavaUtil {
final RefElement refClass = refManager.getReference(javaClass.getOriginalElement());
if (refClass != null) refClass.initializeIfNeeded();
refFrom.addReference(refClass, javaClass.getOriginalElement(), decl, false, true, null);
checkRepeatableAnnotation(javaClass, node);
}
return false;
}
private void checkRepeatableAnnotation(PsiClass annotationClass, UAnnotation annotation) {
if (!CommonClassNames.JAVA_LANG_ANNOTATION_REPEATABLE.equals(annotationClass.getQualifiedName())) return;
UExpression value = annotation.findAttributeValue("value");
while (value instanceof UParenthesizedExpression parenth) {
value = parenth.getExpression();
}
if (!(value instanceof UClassLiteralExpression classLiteralExpression)) return;
PsiClass aClass = PsiUtil.resolveClassInClassTypeOnly(classLiteralExpression.getType());
if (aClass == null) return;
RefClassImpl refClass =
ObjectUtils.tryCast(refManager.getReference(aClass.getOriginalElement()), RefClassImpl.class);
if (refClass == null) return;
refClass.initializeIfNeeded();
for (RefEntity child : refClass.getChildren()) {
if (child instanceof RefMethod method && "value()".equals(method.getName())) {
refFrom.addReference(method, null, decl, false, true, null);
break;
}
}
}
@Override
public boolean visitTypeReferenceExpression(@NotNull UTypeReferenceExpression node) {
PsiType type = node.getType();
@@ -232,7 +254,6 @@ public final class RefJavaUtilImpl extends RefJavaUtil {
boolean writing = isAccessedForWriting(node);
boolean reading = isAccessedForReading(node);
if (refResolved != null) refResolved.initializeIfNeeded();
refFrom.initializeIfNeeded();
refFrom.addReference(refResolved, psiResolved, decl, writing, reading, node);
if (refResolved instanceof RefMethodImpl refMethod) {