MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-06 14:58:06 +07:00
Code Issues Packages Projects Releases Wiki Activity

javadoc inspection: provide add javadoc fix onTheFly (IDEA-147106)

Browse Source
This commit is contained in:
Anna Kozlova
2015-10-30 20:31:35 +01:00
parent 6e00a29a31
commit 020502588a
2 changed files with 61 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/javaDoc/JavaDocLocalInspectionBase.java
+19 -5
View File
@@ -258,7 +258,7 @@ public class JavaDocLocalInspectionBase extends BaseJavaBatchLocalInspectionTool
}
else {
return required
? new ProblemDescriptor[]{createDescriptor(elementToHighlight, REQUIRED_JAVADOC_IS_ABSENT, manager, isOnTheFly)}
? new ProblemDescriptor[]{createRequiredJavadocAbsentDescription(elementToHighlight, manager, isOnTheFly)}
: null;
}
@@ -293,7 +293,7 @@ public class JavaDocLocalInspectionBase extends BaseJavaBatchLocalInspectionTool
final boolean required = isJavaDocRequired(psiClass);
if (docComment == null) {
return required
? new ProblemDescriptor[]{createDescriptor(elementToHighlight, REQUIRED_JAVADOC_IS_ABSENT, manager, isOnTheFly)}
? new ProblemDescriptor[]{createRequiredJavadocAbsentDescription(elementToHighlight, manager, isOnTheFly)}
: null;
}
@@ -398,8 +398,9 @@ public class JavaDocLocalInspectionBase extends BaseJavaBatchLocalInspectionTool
PsiDocComment docComment = psiField.getDocComment();
if (docComment == null) {
final PsiIdentifier nameIdentifier = psiField.getNameIdentifier();
return isJavaDocRequired(psiField)
? new ProblemDescriptor[]{createDescriptor(psiField.getNameIdentifier(), REQUIRED_JAVADOC_IS_ABSENT, manager, isOnTheFly)}
? new ProblemDescriptor[]{createRequiredJavadocAbsentDescription(nameIdentifier, manager, isOnTheFly)}
: null;
}
@@ -418,6 +419,19 @@ public class JavaDocLocalInspectionBase extends BaseJavaBatchLocalInspectionTool
: problems.toArray(new ProblemDescriptor[problems.size()]);
}
private ProblemDescriptor createRequiredJavadocAbsentDescription(@NotNull PsiElement nameIdentifier,
@NotNull InspectionManager manager,
boolean isOnTheFly) {
LocalQuickFix fix = createAddJavadocFix(nameIdentifier, isOnTheFly);
return fix != null ?
createDescriptor(nameIdentifier, REQUIRED_JAVADOC_IS_ABSENT, fix, manager, isOnTheFly):
createDescriptor(nameIdentifier, REQUIRED_JAVADOC_IS_ABSENT, manager, isOnTheFly);
}
protected LocalQuickFix createAddJavadocFix(@NotNull PsiElement nameIdentifier, boolean isOnTheFly) {
return null;
}
@Override
@Nullable
public ProblemDescriptor[] checkMethod(@NotNull PsiMethod psiMethod, @NotNull InspectionManager manager, boolean isOnTheFly) {
@@ -440,8 +454,8 @@ public class JavaDocLocalInspectionBase extends BaseJavaBatchLocalInspectionTool
}
if (superMethods.length == 0) {
final PsiIdentifier nameIdentifier = psiMethod.getNameIdentifier();
return nameIdentifier != null ? new ProblemDescriptor[] { createDescriptor(nameIdentifier, REQUIRED_JAVADOC_IS_ABSENT, manager,
isOnTheFly)} : null;
return nameIdentifier != null ? new ProblemDescriptor[] {
createRequiredJavadocAbsentDescription(nameIdentifier, manager, isOnTheFly)} : null;
}
else {
return null;