MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-01 02:38:59 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-167466 String concatenation in loop inspection: provide additional quick-fix to introduce a new StringBuilder;

Browse Source 
String concatenation in loop is enabled by default now
This commit is contained in:
Tagir Valeev
2017-02-02 14:26:32 +03:00
parent b73c0c1000
commit 0183b826f9
10 changed files with 364 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/stringConcatInLoop/afterIntroduceStringBuilder.java Normal file
View File

@@ -0,0 +1,20 @@
// "Introduce new StringBuilder to update variable 's'" "true"
public class Main {
void test(boolean b) {
String s = "";
if (b) {
StringBuilder sBuilder = new StringBuilder();
for(int i = 0; i<10; i++) {
if(sBuilder.indexOf("a") > 0) {
System.out.println(sBuilder);
break;
}
sBuilder.append(i);
}
s = sBuilder.toString();
}
s = s.trim();
System.out.println(s);
}
}

12
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/stringConcatInLoop/afterParameter.java Normal file
View File

@@ -0,0 +1,12 @@
// "Introduce new StringBuilder to update variable 's'" "true"
public class Main {
void test(String s) {
StringBuilder sBuilder = new StringBuilder(s);
for(int i = 0; i<10; i++) {
sBuilder.append(i);
}
s = sBuilder.toString();
System.out.println(s);
}
}

17
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/stringConcatInLoop/beforeIntroduceStringBuilder.java Normal file
View File

@@ -0,0 +1,17 @@
// "Introduce new StringBuilder to update variable 's'" "true"
public class Main {
void test(boolean b) {
String s = "";
if (b)
for(int i=0; i<10; i++) {
if(s.indexOf("a") > 0) {
System.out.println(s);
break;
}
s+<caret>=i;
}
s = s.trim();
System.out.println(s);
}
}

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/stringConcatInLoop/beforeParameter.java Normal file
View File

@@ -0,0 +1,10 @@
// "Introduce new StringBuilder to update variable 's'" "true"
public class Main {
void test(String s) {
for(int i=0; i<10; i++) {
s+<caret>=i;
}
System.out.println(s);
}
}