From ff72facb5ce22500bf04ba2dabe34114a9bbffa2 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Tue, 10 Jul 2018 12:02:50 +0700 Subject: [PATCH] AddTypeCastFix: disallow void type --- .../codeInsight/daemon/impl/quickfix/AddTypeCastFix.java | 1 + .../daemonCodeAnalyzer/quickFix/addTypeCast/beforeVoid.java | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeVoid.java diff --git a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddTypeCastFix.java b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddTypeCastFix.java index d77078d042d2..4b5bcefa131f 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddTypeCastFix.java +++ b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddTypeCastFix.java @@ -69,6 +69,7 @@ public class AddTypeCastFix extends LocalQuickFixAndIntentionActionOnPsiElement @NotNull PsiElement startElement, @NotNull PsiElement endElement) { return myType.isValid() && + !PsiType.VOID.equals(myType) && PsiTypesUtil.isDenotableType(myType, startElement) && PsiTypesUtil.allTypeParametersResolved(startElement, myType) && startElement.getManager().isInProject(startElement); diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeVoid.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeVoid.java new file mode 100644 index 000000000000..af11271b7924 --- /dev/null +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeVoid.java @@ -0,0 +1,6 @@ +// "Cast to 'void'" "false" +class Test { + void test() { + Runnable r = () -> (System.out.println()); + } +} \ No newline at end of file