From fec27c19edd70b0bd59bdc1d3ced6a247c975bfc Mon Sep 17 00:00:00 2001 From: Sergey Simonchik Date: Thu, 12 Mar 2015 00:34:22 +0300 Subject: [PATCH] immutable map instance can be safely passed outside --- .../EnvironmentVariablesTextFieldWithBrowseButton.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java index 186aa88ceb6e..c5d443f5a039 100644 --- a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java +++ b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java @@ -43,6 +43,7 @@ import java.util.List; public class EnvironmentVariablesTextFieldWithBrowseButton extends TextFieldWithBrowseButton implements UserActivityProviderComponent { + // immutable map instance with reliable user-specified iteration order private Map myEnvs = Collections.emptyMap(); private boolean myPassParentEnvs; private final List myListeners = ContainerUtil.createLockFreeCopyOnWriteList(); @@ -63,7 +64,7 @@ public class EnvironmentVariablesTextFieldWithBrowseButton extends TextFieldWith */ @NotNull public Map getEnvs() { - return Collections.unmodifiableMap(myEnvs); + return myEnvs; } /**