From fe36cbe99ff442efbce129430aca8f31ab3a4c7e Mon Sep 17 00:00:00 2001 From: Mikhail Pyltsin Date: Wed, 24 Sep 2025 13:09:25 +0200 Subject: [PATCH] [java-generation] IJ-CR-176380 IDEA-372740 ConcurrentMap implementation must override putIfAbsent, but that method is not in the Override Methods screen, nor Implement Methods - simplification GitOrigin-RevId: c15b9f8891695bab89b51ca5fab629f096d41a41 --- .../generation/OverrideImplementExploreUtil.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/java/java-psi-impl/src/com/intellij/codeInsight/generation/OverrideImplementExploreUtil.java b/java/java-psi-impl/src/com/intellij/codeInsight/generation/OverrideImplementExploreUtil.java index f06a6bd9ba3a..59c9bdb07bd7 100644 --- a/java/java-psi-impl/src/com/intellij/codeInsight/generation/OverrideImplementExploreUtil.java +++ b/java/java-psi-impl/src/com/intellij/codeInsight/generation/OverrideImplementExploreUtil.java @@ -116,14 +116,7 @@ public class OverrideImplementExploreUtil { HashMap> nameToSignature = new HashMap<>(); for (HierarchicalMethodSignature signature : sigs) { String name = signature.getMethod().getName(); - List previousSignatures = nameToSignature.get(name); - if (previousSignatures == null) { - List list = new ArrayList<>(); - list.add(signature); - nameToSignature.put(name, list); - signatures.add(signature); - continue; - } + List previousSignatures = nameToSignature.computeIfAbsent(name, n -> new ArrayList<>()); boolean addToList = true; for (HierarchicalMethodSignature previousSignature : previousSignatures) { if (!MethodSignatureUtil.areSignaturesErasureEqual(signature, previousSignature)) continue;