From fe2ef4c2f9ec6f7fb1fde8a1690d1af9b08492dc Mon Sep 17 00:00:00 2001
From: Roman Shevchenko <roman.shevchenko@jetbrains.com>
Date: Fri, 22 May 2015 16:27:14 +0200
Subject: [PATCH] java: annotation parsing avoided for simple cases

(optimization + Kotlin compatibility)
---
 .../psi/impl/compiled/ClsAnnotationImpl.java  |  16 ++++---
 .../psi/cls/tree/KeywordAnnotatedClass.class  | Bin 0 -> 791 bytes
 .../testSrc/com/intellij/psi/ClsPsiTest.java  |  43 ++++++++++++++++++
 3 files changed, 53 insertions(+), 6 deletions(-)
 create mode 100644 java/java-tests/testData/psi/cls/tree/KeywordAnnotatedClass.class
 create mode 100644 java/java-tests/testSrc/com/intellij/psi/ClsPsiTest.java

diff --git a/java/java-psi-impl/src/com/intellij/psi/impl/compiled/ClsAnnotationImpl.java b/java/java-psi-impl/src/com/intellij/psi/impl/compiled/ClsAnnotationImpl.java
index 3cdc7dfaa82b..e42d4b8d459b 100644
--- a/java/java-psi-impl/src/com/intellij/psi/impl/compiled/ClsAnnotationImpl.java
+++ b/java/java-psi-impl/src/com/intellij/psi/impl/compiled/ClsAnnotationImpl.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2013 JetBrains s.r.o.
+ * Copyright 2000-2015 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -44,23 +44,27 @@ public class ClsAnnotationImpl extends ClsRepositoryPsiElement<PsiAnnotationStub
       @NotNull
       @Override
       protected ClsJavaCodeReferenceElementImpl compute() {
-        String text = PsiTreeUtil.getRequiredChildOfType(getStub().getPsiElement(), PsiJavaCodeReferenceElement.class).getText();
-        return new ClsJavaCodeReferenceElementImpl(ClsAnnotationImpl.this, text);
+        String annotationText = getStub().getText();
+        int index = annotationText.indexOf('(');
+        String refText = index > 0 ? annotationText.substring(1, index) : annotationText.substring(1);
+        return new ClsJavaCodeReferenceElementImpl(ClsAnnotationImpl.this, refText);
       }
     };
     myParameterList = new AtomicNotNullLazyValue<ClsAnnotationParameterListImpl>() {
       @NotNull
       @Override
       protected ClsAnnotationParameterListImpl compute() {
-        PsiAnnotationParameterList paramList = PsiTreeUtil.getRequiredChildOfType(getStub().getPsiElement(), PsiAnnotationParameterList.class);
-        return new ClsAnnotationParameterListImpl(ClsAnnotationImpl.this, paramList.getAttributes());
+        PsiNameValuePair[] attrs = getStub().getText().indexOf('(') > 0
+            ? PsiTreeUtil.getRequiredChildOfType(getStub().getPsiElement(), PsiAnnotationParameterList.class).getAttributes()
+            : PsiNameValuePair.EMPTY_ARRAY;
+        return new ClsAnnotationParameterListImpl(ClsAnnotationImpl.this, attrs);
       }
     };
   }
 
   @Override
   public void appendMirrorText(int indentLevel, @NotNull StringBuilder buffer) {
-    buffer.append("@").append(myReferenceElement.getValue().getCanonicalText());
+    buffer.append('@').append(myReferenceElement.getValue().getCanonicalText());
     appendText(getParameterList(), indentLevel, buffer);
   }
 
diff --git a/java/java-tests/testData/psi/cls/tree/KeywordAnnotatedClass.class b/java/java-tests/testData/psi/cls/tree/KeywordAnnotatedClass.class
new file mode 100644
index 0000000000000000000000000000000000000000..7dbe64039001e6ba92bf3c2d7948232e80a5c3f6
GIT binary patch
literal 791
zcmah{T~8BH5IwWocG-5TY_VXif`!Ha(Qe=YNg$Zg_<?OO@=@bg$ZdNmx83gI?gH__
zA7y;d_}~xlM;T{Z5H%+5!_3Z|IcM%YGv9xF{RUteWkTV&-*xKp{h1$hs-EXZB9fh&
zE5gtK5ypGsR5-5iy3Vs!PqrfiI>BnhC{IM{RIU-m*4wV~RJ1|R=NFosFZcb3kA^&i
zsm3UD0(s~%hf^OW7@1lh;w+?Lq>(^|kcf^{NGJ|l{PSXrD_t=5P6v+iA{ltXb?TQ*
zxh5@Iswsm|`JT?Non-31@;Zb&{{xrnT*nN_TBEwV%ean+1mVMSe*fkEy@T~*nX}~f
zo7I!r&fUiY`+lpty|+YfSB~;oQ&whD#*2;elS*+llYRHJTPdzRSX!`Yj#7qAq>(|H
zWVKM*)RKD1tZG!Fg1$9d+9Wfv|LS>F*E^c9?T1xevvqStkgiW8OT@F7K3DONH}8xj
z<wqKrBG~Of@&tcVg0MK>xSZlh`GpG!{+ft|0&b*n9YqUcFimK<MaY~*hX;a}qtcI9
zjhf$)gj~aK3%4l(C0efBiw$eO>z@Q|`AEe<Vdun))Ic^>s5pDRU3}9JOH7>Lq0o3C
z?!$i?`xJQRaGRq%`}i|++85mXgz1mNkQ@9end6eUD7p9<R-ERoU~7#Ik;N5`G|Ud|
c4CdHRbDU&<6*|VZU?V3nfosUW28EdX35Z~~!~g&Q

literal 0
HcmV?d00001

diff --git a/java/java-tests/testSrc/com/intellij/psi/ClsPsiTest.java b/java/java-tests/testSrc/com/intellij/psi/ClsPsiTest.java
new file mode 100644
index 000000000000..2cd4c2c4bd61
--- /dev/null
+++ b/java/java-tests/testSrc/com/intellij/psi/ClsPsiTest.java
@@ -0,0 +1,43 @@
+/*
+ * Copyright 2000-2015 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.psi;
+
+import com.intellij.openapi.application.ex.PathManagerEx;
+import com.intellij.openapi.vfs.LocalFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.psi.impl.compiled.ClsFileImpl;
+import com.intellij.testFramework.LightIdeaTestCase;
+
+public class ClsPsiTest extends LightIdeaTestCase {
+  public void testKeywordAnnotatedClass() {
+    PsiModifierList modList = getFile().getClasses()[0].getModifierList();
+    assertNotNull(modList);
+    assertEquals("@pkg.native", modList.getAnnotations()[0].getText());
+  }
+
+  private PsiJavaFile getFile() {
+    return getFile(getTestName(false));
+  }
+
+  private static PsiJavaFile getFile(String name) {
+    String path = PathManagerEx.getTestDataPath() + "/psi/cls/tree/" + name + ".class";
+    VirtualFile file = LocalFileSystem.getInstance().findFileByPath(path);
+    assertNotNull(path, file);
+    PsiFile clsFile = PsiManager.getInstance(getProject()).findFile(file);
+    assertTrue(String.valueOf(clsFile), clsFile instanceof ClsFileImpl);
+    return (PsiJavaFile)clsFile;
+  }
+}
\ No newline at end of file