From fcd775c6839e02a57d8d000cf33c64df9354d2bf Mon Sep 17 00:00:00 2001 From: Alex Plate Date: Thu, 5 Feb 2026 12:46:38 +0200 Subject: [PATCH] DS-7201 DataSpell: add debug logging to file drop handlers Add debug logging to FileDropManager and JupyterFileDropHandler to help diagnose intermittent drag-and-drop test failures. Enable debug logging for com.intellij.openapi.editor in DataSpell UI tests. GitOrigin-RevId: 2d032c12090ab818c8e52cd95cfceefa0cc4f910 --- .../src/com/intellij/openapi/editor/FileDropManager.kt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/FileDropManager.kt b/platform/platform-impl/src/com/intellij/openapi/editor/FileDropManager.kt index 808724f40030..9ae335edb19d 100644 --- a/platform/platform-impl/src/com/intellij/openapi/editor/FileDropManager.kt +++ b/platform/platform-impl/src/com/intellij/openapi/editor/FileDropManager.kt @@ -6,7 +6,8 @@ import com.intellij.ide.util.PsiNavigationSupport import com.intellij.openapi.application.EDT import com.intellij.openapi.application.readAction import com.intellij.openapi.components.Service -import com.intellij.openapi.diagnostic.Logger +import com.intellij.openapi.diagnostic.debug +import com.intellij.openapi.diagnostic.logger import com.intellij.openapi.extensions.ExtensionPointName import com.intellij.openapi.fileEditor.FileDocumentManager import com.intellij.openapi.fileEditor.FileEditorManager @@ -31,7 +32,7 @@ fun containsFileDropTargets(transferFlavors: Array): Boolean { return FileCopyPasteUtil.isFileListFlavorAvailable(transferFlavors) } -private val LOG = Logger.getInstance(FileDropManager::class.java) +private val LOG = logger() private val EP_NAME: ExtensionPointName = ExtensionPointName("com.intellij.fileDropHandler") @@ -41,7 +42,9 @@ class FileDropManager( private val coroutineScope: CoroutineScope, ) { fun scheduleDrop(transferable: Transferable, editor: Editor?, editorWindowCandidate: EditorWindow?) { - val fileList = FileCopyPasteUtil.getFileList(transferable) ?: return + val fileList = FileCopyPasteUtil.getFileList(transferable) + LOG.debug { "FileDropManager.scheduleDrop: extracted ${fileList?.size ?: 0} files from transferable: ${fileList?.map { it.name }}" } + if (fileList == null) return coroutineScope.launch { handleDrop(transferable, editor, editorWindowCandidate, fileList) }