From fc239567e16090958f9e217ba7bd07e009fa28fc Mon Sep 17 00:00:00 2001 From: Kirill Likhodedov Date: Tue, 15 Nov 2011 19:22:45 +0300 Subject: [PATCH] Hide "Push to all branches" checkbox in the push dialog. Reason: the option is not quite clear, and may confuse users. Especially it is confusing in a multi-repo configuration (where "push all branches" might be understood as "push branches from all repositories"). It also doesn't give any visual effect if there are no changes in other branches (commit list stays the same after reloading). The option is hidden, but not removed, because pushing all branches is default for command line 'git push'. Therefore if there is a feedback to implement the option, it will be reconsidered. --- plugins/git4idea/src/git4idea/push/GitPushDialog.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/git4idea/src/git4idea/push/GitPushDialog.java b/plugins/git4idea/src/git4idea/push/GitPushDialog.java index de19b5b6a8e4..797c96c1ed92 100644 --- a/plugins/git4idea/src/git4idea/push/GitPushDialog.java +++ b/plugins/git4idea/src/git4idea/push/GitPushDialog.java @@ -76,6 +76,9 @@ public class GitPushDialog extends DialogWrapper { loadCommitsInBackground(myPushAllCheckbox.isSelected()); } }); + /* hidden: it may confuse users, the target is not clear, hidden until really needed, + not removed completely because it is default behavior for 'git push' in command line. */ + myPushAllCheckbox.setVisible(false); myListPanel = new GitPushLog(myProject, myRepositories, new Consumer() { @Override public void consume(Boolean checked) {