From fb925fba8b0c298fed0bf7ca1a91dded7527d2d8 Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Thu, 17 Sep 2015 12:25:31 +0300 Subject: [PATCH] Cleanup (javadoc corrected; condition optimized) --- .../execution/configurations/EncodingEnvironmentUtil.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/platform/platform-api/src/com/intellij/execution/configurations/EncodingEnvironmentUtil.java b/platform/platform-api/src/com/intellij/execution/configurations/EncodingEnvironmentUtil.java index 7055b126230a..e240e5995346 100644 --- a/platform/platform-api/src/com/intellij/execution/configurations/EncodingEnvironmentUtil.java +++ b/platform/platform-api/src/com/intellij/execution/configurations/EncodingEnvironmentUtil.java @@ -83,12 +83,11 @@ public class EncodingEnvironmentUtil { } private static boolean isLocaleDefined(@NotNull GeneralCommandLine commandLine) { - return isLocaleDefined(commandLine.getEnvironment()) || - commandLine.isPassParentEnvironment() && isLocaleDefined(commandLine.getParentEnvironment()); + return isLocaleDefined(commandLine.getEnvironment()) || isLocaleDefined(commandLine.getParentEnvironment()); } private static boolean isLocaleDefined(@NotNull Map env) { - return env.containsKey(LC_ALL) || env.containsKey(LC_CTYPE) || env.containsKey(LANG); + return !env.isEmpty() && (env.containsKey(LC_CTYPE) || env.containsKey(LC_ALL) || env.containsKey(LANG)); } /** @deprecated use {@link #setLocaleEnvironmentIfMac(GeneralCommandLine)} instead (to be removed in IDEA 16) */ @@ -99,7 +98,7 @@ public class EncodingEnvironmentUtil { } } - /** @deprecated use {@link #setLocaleEnvironmentIfMac(Map, Charset)} instead (to be removed in IDEA 15) */ + /** @deprecated use {@link #setLocaleEnvironmentIfMac(Map, Charset)} instead (to be removed in IDEA 16) */ @SuppressWarnings("unused") public static void fixDefaultEncodingIfMac(@NotNull Map env, @Nullable Project project) { if (SystemInfo.isMac && !isLocaleDefined(env)) {