From fb1f6a609fc3c494701134dcd1f424dc4af458c9 Mon Sep 17 00:00:00 2001
From: Ilya Kazakevich <ilya.kazakevich@jetbrains.com>
Date: Wed, 26 Mar 2025 21:04:20 +0000
Subject: [PATCH] Python: break python validation cycle that led to SO.

`PythonSdkFlavor` checks if file is executable. It is usually enough to validate sdk.

But on Windows we might have appx pythons (from store). They aren't "executable" (not even "exist") from the file system perspective, but still can be executed.


Merge-request: IJ-MR-158490
Merged-by: Ilya Kazakevich <ilya.kazakevich@jetbrains.com>

GitOrigin-RevId: 1fbd4e42d8a5cd94dc55fe6326924cf898bbbcc4
---
 .../sdk/flavors/WinPythonSdkFlavor.java       | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/python/src/com/jetbrains/python/sdk/flavors/WinPythonSdkFlavor.java b/python/src/com/jetbrains/python/sdk/flavors/WinPythonSdkFlavor.java
index df9c3607db9e..641a8bd39864 100644
--- a/python/src/com/jetbrains/python/sdk/flavors/WinPythonSdkFlavor.java
+++ b/python/src/com/jetbrains/python/sdk/flavors/WinPythonSdkFlavor.java
@@ -86,36 +86,36 @@ public class WinPythonSdkFlavor extends CPythonSdkFlavor<PyFlavorData.Empty> {
   }
 
   @Override
-  public boolean sdkSeemsValid(@NotNull Sdk sdk,
-                               PyFlavorData.@NotNull Empty flavorData,
-                               @Nullable TargetEnvironmentConfiguration targetConfig) {
+  public final boolean sdkSeemsValid(@NotNull Sdk sdk,
+                                     PyFlavorData.@NotNull Empty flavorData,
+                                     @Nullable TargetEnvironmentConfiguration targetConfig) {
     if (super.sdkSeemsValid(sdk, flavorData, targetConfig) || targetConfig != null) {
       // non-local, cant check for appx
       return true;
     }
 
-    var path = tryResolvePath(sdk.getHomePath());
-    return path != null && isLocalPathValidPython(path);
+    String path = sdk.getHomePath();
+    return path != null && isValidSdkPath(path);
   }
 
   @Override
-  public boolean isValidSdkPath(final @NotNull String pathStr) {
+  public final boolean isValidSdkPath(final @NotNull String pathStr) {
     if (super.isValidSdkPath(pathStr)) {
-      return true;
+      return true; // File is local and executable
     }
 
     var path = tryResolvePath(pathStr);
-    return path != null && isLocalPathValidPython(path);
+    return path != null && isPythonFromStore(path); // Python from store might be non-executable, but still usable
   }
 
-  private boolean isLocalPathValidPython(@NotNull Path path) {
+  private boolean isPythonFromStore(@NotNull Path path) {
     String pathStr = path.toString();
     if (myAppxCache.getValue().contains(pathStr)) {
       return true;
     }
 
     String product = getAppxProduct(path);
-    return product != null && product.contains(APPX_PRODUCT) && isValidSdkPath(pathStr);
+    return product != null && product.contains(APPX_PRODUCT);
   }
 
   @Override