diff --git a/platform/util/src/com/intellij/openapi/util/JDOMExternalizerUtil.java b/platform/util/src/com/intellij/openapi/util/JDOMExternalizerUtil.java index 597eaf2c54c5..cf94a7e1cc3e 100644 --- a/platform/util/src/com/intellij/openapi/util/JDOMExternalizerUtil.java +++ b/platform/util/src/com/intellij/openapi/util/JDOMExternalizerUtil.java @@ -93,7 +93,7 @@ public class JDOMExternalizerUtil { } if (children.size() == 1) { String value = children.iterator().next().getAttributeValue(Constants.VALUE); - return value == null ? Collections.emptyList() : Collections.singletonList(value); + return value == null ? Collections.emptyList() : Collections.singletonList(value); } List values = ContainerUtil.newArrayListWithCapacity(children.size()); for (Element child : children) { diff --git a/platform/util/src/com/intellij/openapi/util/JDOMUtil.java b/platform/util/src/com/intellij/openapi/util/JDOMUtil.java index 15974eabaa5e..5397a45649a3 100644 --- a/platform/util/src/com/intellij/openapi/util/JDOMUtil.java +++ b/platform/util/src/com/intellij/openapi/util/JDOMUtil.java @@ -71,7 +71,7 @@ public class JDOMUtil { @NotNull public static List getChildren(@Nullable Element parent) { - return parent == null ? Collections.emptyList() : parent.getChildren(); + return parent == null ? Collections.emptyList() : parent.getChildren(); } @NotNull @@ -696,7 +696,7 @@ public class JDOMUtil { @NotNull public static List getAttributes(@NotNull Element e) { // avoid AttributeList creation if no attributes - return e.hasAttributes() ? e.getAttributes() : Collections.emptyList(); + return e.hasAttributes() ? e.getAttributes() : Collections.emptyList(); } @Nullable diff --git a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java index ed5f34d330e7..5256c4fe38d6 100644 --- a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java +++ b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java @@ -1095,7 +1095,7 @@ public class FileUtil extends FileUtilRt { } private static final JBTreeTraverser FILE_TRAVERSER = JBTreeTraverser.from( - (Function>)file -> file != null && file.isDirectory() ? JBIterable.of(file.listFiles()) : JBIterable.empty()); + (Function>)file -> file != null && file.isDirectory() ? JBIterable.of(file.listFiles()) : JBIterable.empty()); public static boolean processFilesRecursively(@NotNull File root, @NotNull Processor processor) { return fileTraverser(root).bfsTraversal().processEach(processor); diff --git a/platform/util/src/com/intellij/openapi/util/objectTree/ObjectTree.java b/platform/util/src/com/intellij/openapi/util/objectTree/ObjectTree.java index ffe4c464d91a..12c22f731eeb 100644 --- a/platform/util/src/com/intellij/openapi/util/objectTree/ObjectTree.java +++ b/platform/util/src/com/intellij/openapi/util/objectTree/ObjectTree.java @@ -206,7 +206,7 @@ public final class ObjectTree { @NotNull final ObjectTreeAction action) { //noinspection SynchronizationOnLocalVariableOrMethodParameter synchronized (recursiveGuard) { - if (ArrayUtil.indexOf(recursiveGuard, object, ContainerUtil.identityStrategy()) != -1) return; + if (ArrayUtil.indexOf(recursiveGuard, object, ContainerUtil.identityStrategy()) != -1) return; recursiveGuard.add(object); } @@ -216,7 +216,7 @@ public final class ObjectTree { finally { //noinspection SynchronizationOnLocalVariableOrMethodParameter synchronized (recursiveGuard) { - int i = ArrayUtil.lastIndexOf(recursiveGuard, object, ContainerUtil.identityStrategy()); + int i = ArrayUtil.lastIndexOf(recursiveGuard, object, ContainerUtil.identityStrategy()); assert i != -1; recursiveGuard.remove(i); } diff --git a/platform/util/src/com/intellij/util/CommonProcessors.java b/platform/util/src/com/intellij/util/CommonProcessors.java index 0990fe93c54e..99b76732ca17 100644 --- a/platform/util/src/com/intellij/util/CommonProcessors.java +++ b/platform/util/src/com/intellij/util/CommonProcessors.java @@ -99,7 +99,7 @@ public class CommonProcessors { private final Processor myDelegate; public UniqueProcessor(@NotNull Processor delegate) { - this(delegate, ContainerUtil.canonicalStrategy()); + this(delegate, ContainerUtil.canonicalStrategy()); } public UniqueProcessor(@NotNull Processor delegate, @NotNull TObjectHashingStrategy strategy) { diff --git a/platform/util/src/com/intellij/util/containers/BidirectionalMultiMap.java b/platform/util/src/com/intellij/util/containers/BidirectionalMultiMap.java index 40bf77a176dc..fe69de3e2bba 100644 --- a/platform/util/src/com/intellij/util/containers/BidirectionalMultiMap.java +++ b/platform/util/src/com/intellij/util/containers/BidirectionalMultiMap.java @@ -41,13 +41,13 @@ public class BidirectionalMultiMap { @NotNull public Set getValues(K key) { Set set = myKey2Values.get(key); - return set != null ? set : Collections.emptySet(); + return set != null ? set : Collections.emptySet(); } @NotNull public Set getKeys(V value) { Set set = myValue2Keys.get(value); - return set != null ? set : Collections.emptySet(); + return set != null ? set : Collections.emptySet(); } public boolean containsKey(K key) { diff --git a/platform/util/src/com/intellij/util/containers/ConcurrentClassMap.java b/platform/util/src/com/intellij/util/containers/ConcurrentClassMap.java index d86f28d2c0eb..c888e1305117 100644 --- a/platform/util/src/com/intellij/util/containers/ConcurrentClassMap.java +++ b/platform/util/src/com/intellij/util/containers/ConcurrentClassMap.java @@ -20,6 +20,6 @@ package com.intellij.util.containers; */ public class ConcurrentClassMap extends ClassMap { public ConcurrentClassMap() { - super(ContainerUtil.newConcurrentMap()); + super(ContainerUtil.newConcurrentMap()); } } diff --git a/platform/util/src/com/intellij/util/containers/ConcurrentFactoryMap.java b/platform/util/src/com/intellij/util/containers/ConcurrentFactoryMap.java index 5f4b06fe3fa7..dc39ac0916b6 100644 --- a/platform/util/src/com/intellij/util/containers/ConcurrentFactoryMap.java +++ b/platform/util/src/com/intellij/util/containers/ConcurrentFactoryMap.java @@ -63,7 +63,7 @@ public abstract class ConcurrentFactoryMap implements ConcurrentMap { private static T notNull(final Object key) { //noinspection unchecked - return key == null ? ConcurrentFactoryMap.FAKE_NULL() : (T)key; + return key == null ? ConcurrentFactoryMap.FAKE_NULL() : (T)key; } @Override @@ -153,7 +153,7 @@ public abstract class ConcurrentFactoryMap implements ConcurrentMap { @Override public V putIfAbsent(@NotNull K key, V value) { - return nullize(myMap.putIfAbsent(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(value))); + return nullize(myMap.putIfAbsent(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(value))); } @Override @@ -163,12 +163,12 @@ public abstract class ConcurrentFactoryMap implements ConcurrentMap { @Override public boolean replace(@NotNull K key, @NotNull V oldValue, @NotNull V newValue) { - return myMap.replace(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(oldValue), ConcurrentFactoryMap.notNull(newValue)); + return myMap.replace(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(oldValue), ConcurrentFactoryMap.notNull(newValue)); } @Override public V replace(@NotNull K key, @NotNull V value) { - return nullize(myMap.replace(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(value))); + return nullize(myMap.replace(ConcurrentFactoryMap.notNull(key), ConcurrentFactoryMap.notNull(value))); } @NotNull @@ -291,7 +291,7 @@ public abstract class ConcurrentFactoryMap implements ConcurrentMap { @Override public V setValue(V value) { - return myEntry.setValue(ConcurrentFactoryMap.notNull(value)); + return myEntry.setValue(ConcurrentFactoryMap.notNull(value)); } @Override diff --git a/platform/util/src/com/intellij/util/containers/ContainerUtil.java b/platform/util/src/com/intellij/util/containers/ContainerUtil.java index 8f762e2e4c12..2476a4297d5e 100644 --- a/platform/util/src/com/intellij/util/containers/ContainerUtil.java +++ b/platform/util/src/com/intellij/util/containers/ContainerUtil.java @@ -309,7 +309,7 @@ public class ContainerUtil extends ContainerUtilRt { @Contract(pure=true) public static Set newHashOrEmptySet(@Nullable Iterable iterable) { boolean empty = iterable == null || iterable instanceof Collection && ((Collection)iterable).isEmpty(); - return empty ? Collections.emptySet() : ContainerUtilRt.newHashSet(iterable); + return empty ? Collections.emptySet() : ContainerUtilRt.newHashSet(iterable); } @NotNull @@ -369,24 +369,24 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(pure=true) public static THashSet newIdentityTroveSet() { - return new THashSet<>(ContainerUtil.identityStrategy()); + return new THashSet<>(ContainerUtil.identityStrategy()); } @NotNull @Contract(pure=true) public static THashSet newIdentityTroveSet(int initialCapacity) { - return new THashSet<>(initialCapacity, ContainerUtil.identityStrategy()); + return new THashSet<>(initialCapacity, ContainerUtil.identityStrategy()); } @NotNull @Contract(pure=true) public static THashSet newIdentityTroveSet(@NotNull Collection collection) { - return new THashSet<>(collection, ContainerUtil.identityStrategy()); + return new THashSet<>(collection, ContainerUtil.identityStrategy()); } @NotNull @Contract(pure=true) public static THashMap newIdentityTroveMap() { - return new THashMap<>(ContainerUtil.identityStrategy()); + return new THashMap<>(ContainerUtil.identityStrategy()); } @NotNull @@ -410,7 +410,7 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(pure=true) public static Set newConcurrentSet() { - return Collections.newSetFromMap(ContainerUtil.newConcurrentMap()); + return Collections.newSetFromMap(ContainerUtil.newConcurrentMap()); } @NotNull @@ -1117,7 +1117,7 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(pure=true) public static Iterator iterate(@NotNull T[] array) { - return array.length == 0 ? EmptyIterator.getInstance() : Arrays.asList(array).iterator(); + return array.length == 0 ? EmptyIterator.getInstance() : Arrays.asList(array).iterator(); } @NotNull @@ -1364,7 +1364,7 @@ public class ContainerUtil extends ContainerUtilRt { for (final Collection ts : list) { result.addAll(ts); } - return result.isEmpty() ? Collections.emptyList() : result; + return result.isEmpty() ? Collections.emptyList() : result; } @NotNull @@ -1528,7 +1528,7 @@ public class ContainerUtil extends ContainerUtilRt { for (final V v : list) { result.addAll(listGenerator.fun(v)); } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } @Contract(pure=true) @@ -1562,7 +1562,7 @@ public class ContainerUtil extends ContainerUtilRt { result.add(t); } } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } @NotNull @@ -1728,7 +1728,7 @@ public class ContainerUtil extends ContainerUtilRt { public static Collection subtract(@NotNull Collection from, @NotNull Collection what) { final Set set = ContainerUtilRt.newHashSet(from); set.removeAll(what); - return set.isEmpty() ? ContainerUtil.emptyList() : set; + return set.isEmpty() ? ContainerUtil.emptyList() : set; } @NotNull @@ -1906,7 +1906,7 @@ public class ContainerUtil extends ContainerUtilRt { for (T t : iterable) { result.add(mapping.fun(t)); } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } /** @@ -1969,7 +1969,7 @@ public class ContainerUtil extends ContainerUtilRt { result.add(o); } } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } /** @@ -1993,7 +1993,7 @@ public class ContainerUtil extends ContainerUtilRt { for (T element : elements) { addIfNotNull(list, element); } - return list.isEmpty() ? ContainerUtil.emptyList() : list; + return list.isEmpty() ? ContainerUtil.emptyList() : list; } /** @@ -2006,7 +2006,7 @@ public class ContainerUtil extends ContainerUtilRt { for (T t : array) { result.add(mapping.fun(t)); } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } @NotNull @@ -2069,13 +2069,13 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(pure=true) public static List createMaybeSingletonList(@Nullable T element) { - return element == null ? ContainerUtil.emptyList() : Collections.singletonList(element); + return element == null ? ContainerUtil.emptyList() : Collections.singletonList(element); } @NotNull @Contract(pure=true) public static Set createMaybeSingletonSet(@Nullable T element) { - return element == null ? Collections.emptySet() : Collections.singleton(element); + return element == null ? Collections.emptySet() : Collections.singleton(element); } @NotNull @@ -2327,7 +2327,7 @@ public class ContainerUtil extends ContainerUtilRt { result.addAll(list); } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } /** @@ -2346,7 +2346,7 @@ public class ContainerUtil extends ContainerUtilRt { result.add(e); } } - return result.isEmpty() ? ContainerUtil.emptyList() : result; + return result.isEmpty() ? ContainerUtil.emptyList() : result; } @NotNull @@ -2475,7 +2475,7 @@ public class ContainerUtil extends ContainerUtilRt { @Contract(value = " -> new", pure = true) public static CopyOnWriteArrayList createEmptyCOWList() { // does not create garbage new Object[0] - return new CopyOnWriteArrayList<>(ContainerUtilRt.emptyList()); + return new CopyOnWriteArrayList<>(ContainerUtilRt.emptyList()); } /** @@ -2564,13 +2564,13 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(value = " -> new", pure = true) public static ConcurrentMap createConcurrentWeakKeySoftValueMap() { - return createConcurrentWeakKeySoftValueMap(100, 0.75f, Runtime.getRuntime().availableProcessors(), ContainerUtil.canonicalStrategy()); + return createConcurrentWeakKeySoftValueMap(100, 0.75f, Runtime.getRuntime().availableProcessors(), ContainerUtil.canonicalStrategy()); } @NotNull @Contract(value = " -> new", pure = true) public static ConcurrentMap createConcurrentWeakKeyWeakValueMap() { - return createConcurrentWeakKeyWeakValueMap(ContainerUtil.canonicalStrategy()); + return createConcurrentWeakKeyWeakValueMap(ContainerUtil.canonicalStrategy()); } @NotNull @@ -2704,7 +2704,7 @@ public class ContainerUtil extends ContainerUtilRt { set.add(value); } } - return set.isEmpty() ? Collections.emptySet() : set; + return set.isEmpty() ? Collections.emptySet() : set; } /** @@ -2790,19 +2790,19 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull @Contract(pure=true) public static List notNullize(@Nullable List list) { - return list == null ? ContainerUtilRt.emptyList() : list; + return list == null ? ContainerUtilRt.emptyList() : list; } @NotNull @Contract(pure=true) public static Set notNullize(@Nullable Set set) { - return set == null ? Collections.emptySet() : set; + return set == null ? Collections.emptySet() : set; } @NotNull @Contract(pure = true) public static Map notNullize(@Nullable Map map) { - return map == null ? Collections.emptyMap() : map; + return map == null ? Collections.emptyMap() : map; } @Contract(pure = true) @@ -2910,7 +2910,7 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull public static Map createSoftValueMap() { //noinspection deprecation - return new SoftValueHashMap<>(ContainerUtil.canonicalStrategy()); + return new SoftValueHashMap<>(ContainerUtil.canonicalStrategy()); } /** @@ -2922,7 +2922,7 @@ public class ContainerUtil extends ContainerUtilRt { @NotNull public static Map createWeakValueMap() { //noinspection deprecation - return new WeakValueHashMap<>(ContainerUtil.canonicalStrategy()); + return new WeakValueHashMap<>(ContainerUtil.canonicalStrategy()); } /** @@ -2958,7 +2958,7 @@ public class ContainerUtil extends ContainerUtilRt { @Contract(value = "_ -> new", pure = true) @NotNull public static Map createWeakMap(int initialCapacity) { - return createWeakMap(initialCapacity, 0.8f, ContainerUtil.canonicalStrategy()); + return createWeakMap(initialCapacity, 0.8f, ContainerUtil.canonicalStrategy()); } @Contract(value = "_, _, _ -> new", pure = true) diff --git a/platform/util/src/com/intellij/util/containers/FactoryMap.java b/platform/util/src/com/intellij/util/containers/FactoryMap.java index aad7262d79ea..aeb45288153c 100644 --- a/platform/util/src/com/intellij/util/containers/FactoryMap.java +++ b/platform/util/src/com/intellij/util/containers/FactoryMap.java @@ -86,7 +86,7 @@ public abstract class FactoryMap implements Map { private static T notNull(final Object key) { //noinspection unchecked - return key == null ? FactoryMap.FAKE_NULL() : (T)key; + return key == null ? FactoryMap.FAKE_NULL() : (T)key; } @Nullable private static T nullize(T value) { diff --git a/platform/util/src/com/intellij/util/containers/FilteredTraverserBase.java b/platform/util/src/com/intellij/util/containers/FilteredTraverserBase.java index 0040d86235d2..3fa904961819 100644 --- a/platform/util/src/com/intellij/util/containers/FilteredTraverserBase.java +++ b/platform/util/src/com/intellij/util/containers/FilteredTraverserBase.java @@ -35,7 +35,7 @@ public abstract class FilteredTraverserBase meta, @NotNull Function> tree) { this.myTree = tree; - this.myMeta = meta == null ? Meta.empty() : meta; + this.myMeta = meta == null ? Meta.empty() : meta; } @NotNull @@ -397,7 +397,7 @@ public abstract class FilteredTraverserBase EMPTY = new Meta( JBIterable.empty(), TreeTraversal.PRE_ORDER_DFS, Cond.TRUE, Cond.TRUE, Cond.TRUE, - Cond.FALSE, Cond.FALSE, Functions.id()); + Cond.FALSE, Cond.FALSE, Functions.id()); public static Meta empty() { return (Meta)EMPTY; diff --git a/platform/util/src/com/intellij/util/containers/FilteringIterator.java b/platform/util/src/com/intellij/util/containers/FilteringIterator.java index 45ce2ef24de1..0f18eceb73f6 100644 --- a/platform/util/src/com/intellij/util/containers/FilteringIterator.java +++ b/platform/util/src/com/intellij/util/containers/FilteringIterator.java @@ -99,7 +99,7 @@ public class FilteringIterator implements PeekableIterator Iterator skipNulls(Iterator iterator) { - return create(iterator, Conditions.notNull()); + return create(iterator, Conditions.notNull()); } public static Iterator create(Iterator iterator, Condition condition) { diff --git a/platform/util/src/com/intellij/util/containers/JBIterable.java b/platform/util/src/com/intellij/util/containers/JBIterable.java index 11d776e51308..8c923526ea21 100644 --- a/platform/util/src/com/intellij/util/containers/JBIterable.java +++ b/platform/util/src/com/intellij/util/containers/JBIterable.java @@ -176,7 +176,7 @@ public abstract class JBIterable implements Iterable { */ @NotNull public static JBIterable of(@Nullable E... elements) { - return elements == null || elements.length == 0 ? JBIterable.empty() : from(ContainerUtilRt.newArrayList(elements)); + return elements == null || elements.length == 0 ? JBIterable.empty() : from(ContainerUtilRt.newArrayList(elements)); } private static final JBIterable EMPTY = new Empty(); @@ -627,7 +627,7 @@ public abstract class JBIterable implements Iterable { */ @NotNull public final JBIterable filterMap(@NotNull Function function) { - return map(function).filter(Conditions.notNull()); + return map(function).filter(Conditions.notNull()); } /** @@ -668,7 +668,7 @@ public abstract class JBIterable implements Iterable { @NotNull public final JBIterable> split(final int size, final boolean strict) { return split(size).filterMap(es -> { - List list = es.addAllTo(ContainerUtilRt.newArrayListWithCapacity(size)); + List list = es.addAllTo(ContainerUtilRt.newArrayListWithCapacity(size)); return strict && list.size() < size ? null : list; }); } @@ -795,7 +795,7 @@ public abstract class JBIterable implements Iterable { @NotNull public final JBIterable collect() { if (content instanceof Collection) return this; - return collect(ContainerUtilRt.newArrayList()); + return collect(ContainerUtilRt.newArrayList()); } /** @@ -804,7 +804,7 @@ public abstract class JBIterable implements Iterable { */ @NotNull public final JBIterable sort(@NotNull Comparator comparator) { - ArrayList list = addAllTo(ContainerUtilRt.newArrayList()); + ArrayList list = addAllTo(ContainerUtilRt.newArrayList()); list.sort(comparator); return from(list); } @@ -857,7 +857,7 @@ public abstract class JBIterable implements Iterable { public final Map toMap(@NotNull Convertor toKey, @NotNull Convertor toValue) { Map map = ContainerUtil.newLinkedHashMap(); for (E e : this) map.put(toKey.convert(e), toValue.convert(e)); - return map.isEmpty() ? Collections.emptyMap() : Collections.unmodifiableMap(map); + return map.isEmpty() ? Collections.emptyMap() : Collections.unmodifiableMap(map); } /** diff --git a/platform/util/src/com/intellij/util/containers/JBIterator.java b/platform/util/src/com/intellij/util/containers/JBIterator.java index fa50c06d5269..4ad81cba9d65 100644 --- a/platform/util/src/com/intellij/util/containers/JBIterator.java +++ b/platform/util/src/com/intellij/util/containers/JBIterator.java @@ -52,7 +52,7 @@ public abstract class JBIterator implements Iterator { @NotNull public static > JBIterable cursor(@NotNull E iterator) { - return JBIterable.generate(iterator, Functions.id()).intercept(CURSOR_NEXT); + return JBIterable.generate(iterator, Functions.id()).intercept(CURSOR_NEXT); } @NotNull diff --git a/platform/util/src/com/intellij/util/containers/JBTreeTraverser.java b/platform/util/src/com/intellij/util/containers/JBTreeTraverser.java index aed604763066..f114181ee30d 100644 --- a/platform/util/src/com/intellij/util/containers/JBTreeTraverser.java +++ b/platform/util/src/com/intellij/util/containers/JBTreeTraverser.java @@ -28,7 +28,7 @@ public class JBTreeTraverser extends FilteredTraverserBase JBTreeTraverser of(@NotNull Function treeStructure) { - return new JBTreeTraverser<>(Functions.compose(treeStructure, Functions.wrapArray())); + return new JBTreeTraverser<>(Functions.compose(treeStructure, Functions.wrapArray())); } public JBTreeTraverser(Function> treeStructure) { diff --git a/platform/util/src/com/intellij/util/containers/LockFreeCopyOnWriteArrayList.java b/platform/util/src/com/intellij/util/containers/LockFreeCopyOnWriteArrayList.java index b4aaa1b189af..a16ef34e252a 100644 --- a/platform/util/src/com/intellij/util/containers/LockFreeCopyOnWriteArrayList.java +++ b/platform/util/src/com/intellij/util/containers/LockFreeCopyOnWriteArrayList.java @@ -881,7 +881,7 @@ class LockFreeCopyOnWriteArrayList implements List, RandomAccess, Concurre throw new IndexOutOfBoundsException("Index: " + index); } - return elements.length == 0 ? EmptyListIterator.getInstance() : new COWIterator(elements, index); + return elements.length == 0 ? EmptyListIterator.getInstance() : new COWIterator(elements, index); } private class COWIterator implements ListIterator { diff --git a/platform/util/src/com/intellij/util/containers/MultiMap.java b/platform/util/src/com/intellij/util/containers/MultiMap.java index 9347212b0c2b..6ea1c3530dac 100644 --- a/platform/util/src/com/intellij/util/containers/MultiMap.java +++ b/platform/util/src/com/intellij/util/containers/MultiMap.java @@ -338,7 +338,7 @@ public class MultiMap implements Serializable { @NotNull public static MultiMap createSet() { - return createSet(ContainerUtil.canonicalStrategy()); + return createSet(ContainerUtil.canonicalStrategy()); } @NotNull diff --git a/platform/util/src/com/intellij/util/containers/OrderedSet.java b/platform/util/src/com/intellij/util/containers/OrderedSet.java index 26665a076111..f330bbcbb783 100644 --- a/platform/util/src/com/intellij/util/containers/OrderedSet.java +++ b/platform/util/src/com/intellij/util/containers/OrderedSet.java @@ -26,7 +26,7 @@ public class OrderedSet extends ArrayList implements Set, RandomAccess private final OpenTHashSet myHashSet; public OrderedSet() { - this(ContainerUtil.canonicalStrategy()); + this(ContainerUtil.canonicalStrategy()); } public OrderedSet(@NotNull Collection set) { @@ -45,7 +45,7 @@ public class OrderedSet extends ArrayList implements Set, RandomAccess } public OrderedSet(int capacity) { - this(ContainerUtil.canonicalStrategy(), capacity); + this(ContainerUtil.canonicalStrategy(), capacity); } @Override diff --git a/platform/util/src/com/intellij/util/containers/RefHashMap.java b/platform/util/src/com/intellij/util/containers/RefHashMap.java index c4a9531faf33..5f6607dd69d1 100644 --- a/platform/util/src/com/intellij/util/containers/RefHashMap.java +++ b/platform/util/src/com/intellij/util/containers/RefHashMap.java @@ -42,7 +42,7 @@ abstract class RefHashMap extends AbstractMap implements Map { } RefHashMap(int initialCapacity, float loadFactor) { - this(initialCapacity, loadFactor, ContainerUtil.canonicalStrategy()); + this(initialCapacity, loadFactor, ContainerUtil.canonicalStrategy()); } RefHashMap(int initialCapacity) { diff --git a/platform/util/src/com/intellij/util/containers/SoftArrayHashMap.java b/platform/util/src/com/intellij/util/containers/SoftArrayHashMap.java index 3165f2532982..ab1513c0e46d 100644 --- a/platform/util/src/com/intellij/util/containers/SoftArrayHashMap.java +++ b/platform/util/src/com/intellij/util/containers/SoftArrayHashMap.java @@ -31,7 +31,7 @@ public class SoftArrayHashMap implements Cloneable { private final TObjectHashingStrategy myStrategy; public SoftArrayHashMap() { - this(ContainerUtil.canonicalStrategy()); + this(ContainerUtil.canonicalStrategy()); } public SoftArrayHashMap(@NotNull TObjectHashingStrategy strategy) { diff --git a/platform/util/src/com/intellij/util/containers/TransferToEDTQueue.java b/platform/util/src/com/intellij/util/containers/TransferToEDTQueue.java index 099c61af4dd3..9eae981dbbd6 100644 --- a/platform/util/src/com/intellij/util/containers/TransferToEDTQueue.java +++ b/platform/util/src/com/intellij/util/containers/TransferToEDTQueue.java @@ -137,7 +137,7 @@ public class TransferToEDTQueue { } public boolean offerIfAbsent(@NotNull T thing) { - return offerIfAbsent(thing, ContainerUtil.canonicalStrategy()); + return offerIfAbsent(thing, ContainerUtil.canonicalStrategy()); } public boolean offerIfAbsent(@NotNull final T thing, @NotNull final Equality equality) { diff --git a/platform/util/src/com/intellij/util/containers/TreeTraversal.java b/platform/util/src/com/intellij/util/containers/TreeTraversal.java index 3217b3400677..5e096fa976ed 100644 --- a/platform/util/src/com/intellij/util/containers/TreeTraversal.java +++ b/platform/util/src/com/intellij/util/containers/TreeTraversal.java @@ -394,7 +394,7 @@ public abstract class TreeTraversal { @NotNull public JBIterable backtrace() { if (cur == null) throw new NoSuchElementException(); - return _transform(JBIterable.generate(cur, P.toPrev()).filterMap(P.toNode())); + return _transform(JBIterable.generate(cur, P.toPrev()).filterMap(P.toNode())); } } @@ -570,7 +570,7 @@ public abstract class TreeTraversal { private final static class TracingBfsIt extends TracingIt { final ArrayDeque queue = new ArrayDeque<>(); - final Map paths = ContainerUtil.newTroveMap(ContainerUtil.identityStrategy()); + final Map paths = ContainerUtil.newTroveMap(ContainerUtil.identityStrategy()); P1 top; P1 cur; diff --git a/platform/util/src/com/intellij/util/containers/UnsafeWeakList.java b/platform/util/src/com/intellij/util/containers/UnsafeWeakList.java index a929564aa26a..ead0171fec38 100644 --- a/platform/util/src/com/intellij/util/containers/UnsafeWeakList.java +++ b/platform/util/src/com/intellij/util/containers/UnsafeWeakList.java @@ -232,7 +232,7 @@ public class UnsafeWeakList extends AbstractCollection { } @NotNull public List toStrongList() { - return ContainerUtil.mapNotNull(myList, UnsafeWeakList.deref()); + return ContainerUtil.mapNotNull(myList, UnsafeWeakList.deref()); } /** diff --git a/platform/util/src/com/intellij/util/diff/Diff.java b/platform/util/src/com/intellij/util/diff/Diff.java index d74188fe0788..e0ee9bd00609 100644 --- a/platform/util/src/com/intellij/util/diff/Diff.java +++ b/platform/util/src/com/intellij/util/diff/Diff.java @@ -60,7 +60,7 @@ public class Diff { if (changeRef != null) return changeRef.get(); int trimmedLength = objects1.length + objects2.length - 2 * startShift - 2 * endCut; - Enumerator enumerator = new Enumerator<>(trimmedLength, ContainerUtil.canonicalStrategy()); + Enumerator enumerator = new Enumerator<>(trimmedLength, ContainerUtil.canonicalStrategy()); int[] ints1 = enumerator.enumerate(objects1, startShift, endCut); int[] ints2 = enumerator.enumerate(objects2, startShift, endCut); return doBuildChanges(ints1, ints2, new ChangeBuilder(startShift)); diff --git a/platform/util/src/com/intellij/util/diff/DiffTree.java b/platform/util/src/com/intellij/util/diff/DiffTree.java index 9e97d523c911..4d8484197071 100644 --- a/platform/util/src/com/intellij/util/diff/DiffTree.java +++ b/platform/util/src/com/intellij/util/diff/DiffTree.java @@ -277,7 +277,7 @@ public class DiffTree { CompareResult c11 = looksEqual(oldChild, newChild); if (c11 == CompareResult.DRILL_DOWN_NEEDED) { - c11 = textMatch(oldChild, newChild) ? build(oldChild, newChild, level + 1, DiffTree.emptyConsumer()) : CompareResult.NOT_EQUAL; + c11 = textMatch(oldChild, newChild) ? build(oldChild, newChild, level + 1, DiffTree.emptyConsumer()) : CompareResult.NOT_EQUAL; assert c11 != CompareResult.DRILL_DOWN_NEEDED; } if (c11 != CompareResult.EQUAL) { diff --git a/platform/util/src/com/intellij/util/graph/CachingSemiGraph.java b/platform/util/src/com/intellij/util/graph/CachingSemiGraph.java index b7d5be9d8c3e..4802b62c1146 100644 --- a/platform/util/src/com/intellij/util/graph/CachingSemiGraph.java +++ b/platform/util/src/com/intellij/util/graph/CachingSemiGraph.java @@ -57,7 +57,7 @@ public class CachingSemiGraph implements GraphGenerator.SemiGraph { final List inNodes = myIn.get(n); return inNodes != null ? inNodes.iterator() - : ContainerUtil.emptyIterator(); + : ContainerUtil.emptyIterator(); } } \ No newline at end of file diff --git a/platform/util/src/com/intellij/util/graph/GraphGenerator.java b/platform/util/src/com/intellij/util/graph/GraphGenerator.java index 9072299c0766..03cfa476f9e3 100644 --- a/platform/util/src/com/intellij/util/graph/GraphGenerator.java +++ b/platform/util/src/com/intellij/util/graph/GraphGenerator.java @@ -84,7 +84,7 @@ public class GraphGenerator implements Graph { final List outNodes = myOuts.get(n); return outNodes != null ? outNodes.iterator() - : ContainerUtil.emptyIterator(); + : ContainerUtil.emptyIterator(); } // diff --git a/platform/util/src/com/intellij/util/indexing/impl/CollectionInputDataDiffBuilder.java b/platform/util/src/com/intellij/util/indexing/impl/CollectionInputDataDiffBuilder.java index 53a3595b0dd4..972bfaa7c964 100644 --- a/platform/util/src/com/intellij/util/indexing/impl/CollectionInputDataDiffBuilder.java +++ b/platform/util/src/com/intellij/util/indexing/impl/CollectionInputDataDiffBuilder.java @@ -30,7 +30,7 @@ public class CollectionInputDataDiffBuilder extends InputDataDiffBui public CollectionInputDataDiffBuilder(int inputId, @Nullable Collection seq) { super(inputId); - mySeq = seq == null ? Collections.emptySet() : seq; + mySeq = seq == null ? Collections.emptySet() : seq; } @Override diff --git a/platform/util/src/com/intellij/util/indexing/impl/MapInputDataDiffBuilder.java b/platform/util/src/com/intellij/util/indexing/impl/MapInputDataDiffBuilder.java index 26977c057efa..9dfbb4a911c1 100644 --- a/platform/util/src/com/intellij/util/indexing/impl/MapInputDataDiffBuilder.java +++ b/platform/util/src/com/intellij/util/indexing/impl/MapInputDataDiffBuilder.java @@ -37,7 +37,7 @@ public class MapInputDataDiffBuilder extends InputDataDiffBuilder map) { super(inputId); - myMap = map == null ? Collections.emptyMap() : map; + myMap = map == null ? Collections.emptyMap() : map; } @Override diff --git a/platform/util/src/com/intellij/util/io/zip/ReorderJarsMain.java b/platform/util/src/com/intellij/util/io/zip/ReorderJarsMain.java index ff5ec1e1256c..b72ab776a743 100644 --- a/platform/util/src/com/intellij/util/io/zip/ReorderJarsMain.java +++ b/platform/util/src/com/intellij/util/io/zip/ReorderJarsMain.java @@ -18,7 +18,6 @@ package com.intellij.util.io.zip; import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.util.text.StringUtil; import com.intellij.util.containers.ContainerUtil; -import java.util.HashMap; import com.intellij.util.lang.JarMemoryLoader; import java.io.File; @@ -40,7 +39,7 @@ public class ReorderJarsMain { final String libPath = args.length > 3 ? args[3] : null; final Map> toReorder = getOrder(new File(orderTxtPath)); - final Set ignoredJars = libPath == null ? Collections.emptySet() : loadIgnoredJars(libPath); + final Set ignoredJars = libPath == null ? Collections.emptySet() : loadIgnoredJars(libPath); for (String jarUrl : toReorder.keySet()) { if (ignoredJars.contains(StringUtil.trimStart(jarUrl, "/lib/"))) continue; diff --git a/platform/util/src/com/intellij/util/lang/CompoundRuntimeException.java b/platform/util/src/com/intellij/util/lang/CompoundRuntimeException.java index 8eb48ec77f09..f4e6c186b958 100644 --- a/platform/util/src/com/intellij/util/lang/CompoundRuntimeException.java +++ b/platform/util/src/com/intellij/util/lang/CompoundRuntimeException.java @@ -49,17 +49,17 @@ public class CompoundRuntimeException extends RuntimeException { @Override public String getMessage() { - return processAll(Throwable::getMessage, EmptyConsumer.getInstance()); + return processAll(Throwable::getMessage, EmptyConsumer.getInstance()); } @Override public String getLocalizedMessage() { - return processAll(Throwable::getLocalizedMessage, EmptyConsumer.getInstance()); + return processAll(Throwable::getLocalizedMessage, EmptyConsumer.getInstance()); } @Override public String toString() { - return processAll(Throwable::toString, EmptyConsumer.getInstance()); + return processAll(Throwable::toString, EmptyConsumer.getInstance()); } @Override diff --git a/platform/util/src/com/intellij/util/messages/impl/MessageBusImpl.java b/platform/util/src/com/intellij/util/messages/impl/MessageBusImpl.java index ee20de550283..a4e4af63a8df 100644 --- a/platform/util/src/com/intellij/util/messages/impl/MessageBusImpl.java +++ b/platform/util/src/com/intellij/util/messages/impl/MessageBusImpl.java @@ -400,7 +400,7 @@ public class MessageBusImpl implements MessageBus { } } while (true); - return exceptions == null ? Collections.emptyList() : exceptions; + return exceptions == null ? Collections.emptyList() : exceptions; } void notifyOnSubscription(@NotNull MessageBusConnectionImpl connection, @NotNull Topic topic) { diff --git a/platform/util/src/com/intellij/util/text/FilePathHashingStrategy.java b/platform/util/src/com/intellij/util/text/FilePathHashingStrategy.java index 5ba0ddeb10e9..bb7c05fb1ec0 100644 --- a/platform/util/src/com/intellij/util/text/FilePathHashingStrategy.java +++ b/platform/util/src/com/intellij/util/text/FilePathHashingStrategy.java @@ -33,6 +33,6 @@ public class FilePathHashingStrategy { @NotNull public static TObjectHashingStrategy create(boolean caseSensitive) { - return caseSensitive ? ContainerUtil.canonicalStrategy() : CaseInsensitiveStringHashingStrategy.INSTANCE; + return caseSensitive ? ContainerUtil.canonicalStrategy() : CaseInsensitiveStringHashingStrategy.INSTANCE; } } diff --git a/platform/util/src/com/intellij/util/ui/FontInfo.java b/platform/util/src/com/intellij/util/ui/FontInfo.java index 9d93d43243ad..ace17e3876e0 100644 --- a/platform/util/src/com/intellij/util/ui/FontInfo.java +++ b/platform/util/src/com/intellij/util/ui/FontInfo.java @@ -94,7 +94,7 @@ public final class FontInfo { */ public static List getAll(boolean withAllStyles) { return GraphicsEnvironment.isHeadless() - ? Collections.emptyList() + ? Collections.emptyList() : withAllStyles ? LazyListByFont.LIST : LazyListByName.LIST; diff --git a/platform/util/src/com/intellij/util/ui/UIUtil.java b/platform/util/src/com/intellij/util/ui/UIUtil.java index 541a03e92262..46e113a50477 100644 --- a/platform/util/src/com/intellij/util/ui/UIUtil.java +++ b/platform/util/src/com/intellij/util/ui/UIUtil.java @@ -908,7 +908,7 @@ public class UIUtil { public static void setEnabled(@NotNull Component component, boolean enabled, boolean recursively, final boolean visibleOnly) { JBIterable all = recursively ? uiTraverser(component).expandAndFilter( - visibleOnly ? (Condition)Component::isVisible : Conditions.alwaysTrue()).traverse() : JBIterable.of(component); + visibleOnly ? (Condition)Component::isVisible : Conditions.alwaysTrue()).traverse() : JBIterable.of(component); Color fg = enabled ? getLabelForeground() : getLabelDisabledForeground(); for (Component c : all) { c.setEnabled(enabled); diff --git a/platform/util/src/com/intellij/util/ui/tree/WideSelectionTreeUI.java b/platform/util/src/com/intellij/util/ui/tree/WideSelectionTreeUI.java index a3d146d85311..107c139456e7 100644 --- a/platform/util/src/com/intellij/util/ui/tree/WideSelectionTreeUI.java +++ b/platform/util/src/com/intellij/util/ui/tree/WideSelectionTreeUI.java @@ -66,7 +66,7 @@ public class WideSelectionTreeUI extends BasicTreeUI { private static final boolean mySkinny = false; public WideSelectionTreeUI() { - this(true, Conditions.alwaysTrue()); + this(true, Conditions.alwaysTrue()); } /** diff --git a/platform/util/src/com/intellij/util/xmlb/AbstractCollectionBinding.java b/platform/util/src/com/intellij/util/xmlb/AbstractCollectionBinding.java index 64ec97625f00..51083021f2f1 100644 --- a/platform/util/src/com/intellij/util/xmlb/AbstractCollectionBinding.java +++ b/platform/util/src/com/intellij/util/xmlb/AbstractCollectionBinding.java @@ -74,7 +74,7 @@ abstract class AbstractCollectionBinding extends NotNullDeserializeBinding imple Binding binding = serializer.getBinding(itemType); Class[] elementTypes = getElementTypes(); if (elementTypes.length == 0) { - itemBindings = binding == null ? Collections.emptyList() : Collections.singletonList(binding); + itemBindings = binding == null ? Collections.emptyList() : Collections.singletonList(binding); } else { itemBindings = new SmartList<>(); diff --git a/platform/util/src/com/intellij/util/xmlb/JDOMXIncluder.java b/platform/util/src/com/intellij/util/xmlb/JDOMXIncluder.java index 9db099947b21..5bf35795df88 100644 --- a/platform/util/src/com/intellij/util/xmlb/JDOMXIncluder.java +++ b/platform/util/src/com/intellij/util/xmlb/JDOMXIncluder.java @@ -220,7 +220,7 @@ public class JDOMXIncluder { } else { Element resolvedElement = resolveNonXIncludeElement(original, bases); - return Collections.singletonList(resolvedElement); + return Collections.singletonList(resolvedElement); } } diff --git a/platform/util/src/com/intellij/util/xmlb/MapBinding.java b/platform/util/src/com/intellij/util/xmlb/MapBinding.java index b4c57f48a263..465d9d2bcdf8 100644 --- a/platform/util/src/com/intellij/util/xmlb/MapBinding.java +++ b/platform/util/src/com/intellij/util/xmlb/MapBinding.java @@ -251,7 +251,7 @@ class MapBinding extends Binding implements MultiNodeBinding { } else { Element entryChild = entry.getChild(attributeName); - List children = entryChild == null ? Collections.emptyList() : entryChild.getChildren(); + List children = entryChild == null ? Collections.emptyList() : entryChild.getChildren(); if (children.isEmpty()) { return null; }