From f9c75e076df7990f3fe2f90a48dfe95a5be70307 Mon Sep 17 00:00:00 2001 From: "Vladislav.Soroka" Date: Wed, 20 Mar 2019 14:30:48 +0300 Subject: [PATCH] IDEA-CR-45146: project data save should use caller thread including edt It's a caller responsibility to choose which thread will be used for a project save. There are use cases when the caller wants to use synchronous project e.g. StoreUtil.saveDocumentsAndProjectSettings. --- .../service/project/manage/ExternalProjectsDataStorage.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/ExternalProjectsDataStorage.java b/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/ExternalProjectsDataStorage.java index b192ebb6b848..bd0a98afdb21 100644 --- a/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/ExternalProjectsDataStorage.java +++ b/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/ExternalProjectsDataStorage.java @@ -3,7 +3,6 @@ package com.intellij.openapi.externalSystem.service.project.manage; import com.intellij.concurrency.ConcurrentCollectionFactory; import com.intellij.configurationStore.SettingsSavingComponentJavaAdapter; -import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.PathManagerEx; import com.intellij.openapi.components.*; import com.intellij.openapi.diagnostic.Logger; @@ -140,9 +139,6 @@ public class ExternalProjectsDataStorage implements SettingsSavingComponentJavaA if (!changed.compareAndSet(true, false)) { return; } - if (!ApplicationManager.getApplication().isUnitTestMode()) { - LOG.assertTrue(!ApplicationManager.getApplication().isDispatchThread(), "Should not be called on EDT"); - } try { doSave(myProject, myExternalRootProjects.values()); }