From f8d33e720cb696170b53fe64be88606941c8fd60 Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Tue, 17 Oct 2017 09:58:05 +0200 Subject: [PATCH] [updater] uses native temp. directory creation ... to reduce the possibility of patchers running in parallel reuse the same directory; as suggested in PR #647 (https://github.com/JetBrains/intellij-community/pull/647) --- updater/src/com/intellij/updater/Utils.java | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/updater/src/com/intellij/updater/Utils.java b/updater/src/com/intellij/updater/Utils.java index ad58ce5ac286..3867eb08c2e8 100644 --- a/updater/src/com/intellij/updater/Utils.java +++ b/updater/src/com/intellij/updater/Utils.java @@ -1,18 +1,4 @@ -/* - * Copyright 2000-2017 JetBrains s.r.o. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ +// Copyright 2000-2017 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. package com.intellij.updater; import java.io.*; @@ -66,8 +52,7 @@ public class Utils { public static File getTempFile(String name) throws IOException { if (myTempDir == null) { - myTempDir = findUniqueName(findDirectory(REQUIRED_FREE_SPACE) + "/idea.updater.files"); - if (!myTempDir.mkdirs()) throw new IOException("Cannot create working directory: " + myTempDir); + myTempDir = Files.createTempDirectory(Paths.get(findDirectory(REQUIRED_FREE_SPACE)), "idea.updater.files.").toFile(); Runner.logger().info("created working directory: " + myTempDir); } return findUniqueName(myTempDir.getPath() + '/' + name);