From f8b0121a487e1f017255c350581ad4e84dbe3a77 Mon Sep 17 00:00:00 2001
From: Semyon Proshev <Semyon.Proshev@jetbrains.com>
Date: Mon, 21 Nov 2016 21:42:21 +0300
Subject: [PATCH] PY-19723 Fixed: Type hinting of arbitrary argument lists and
 default argument values

Update PyNamedParameterImpl to return collection types with unknown elements instead of tuple and dict.
---
 .../jetbrains/python/psi/impl/PyNamedParameterImpl.java   | 4 ++--
 python/testSrc/com/jetbrains/python/PyTypeTest.java       | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/python/src/com/jetbrains/python/psi/impl/PyNamedParameterImpl.java b/python/src/com/jetbrains/python/psi/impl/PyNamedParameterImpl.java
index 087efff41834..326cbf8ca852 100644
--- a/python/src/com/jetbrains/python/psi/impl/PyNamedParameterImpl.java
+++ b/python/src/com/jetbrains/python/psi/impl/PyNamedParameterImpl.java
@@ -223,10 +223,10 @@ public class PyNamedParameterImpl extends PyBaseElementImpl<PyNamedParameterStub
           }
         }
         if (isKeywordContainer()) {
-          return PyBuiltinCache.getInstance(this).getDictType();
+          return PyTypeUtil.toKeywordContainerType(this, null);
         }
         if (isPositionalContainer()) {
-          return PyBuiltinCache.getInstance(this).getTupleType();
+          return PyTypeUtil.toPositionalContainerType(this, null);
         }
         if (context.maySwitchToAST(this)) {
           final PyExpression defaultValue = getDefaultValue();
diff --git a/python/testSrc/com/jetbrains/python/PyTypeTest.java b/python/testSrc/com/jetbrains/python/PyTypeTest.java
index d079e67f688d..dfa1371b9f0f 100644
--- a/python/testSrc/com/jetbrains/python/PyTypeTest.java
+++ b/python/testSrc/com/jetbrains/python/PyTypeTest.java
@@ -1448,6 +1448,14 @@ public class PyTypeTest extends PyTestCase {
            "    expr = kwargs");
   }
 
+  // PY-19723
+  public void testIterateOverKeywordArgs() {
+    doTest("str",
+           "def foo(**kwargs):\n" +
+           "    for expr in kwargs:\n" +
+           "        pass");
+  }
+
   private static List<TypeEvalContext> getTypeEvalContexts(@NotNull PyExpression element) {
     return ImmutableList.of(TypeEvalContext.codeAnalysis(element.getProject(), element.getContainingFile()).withTracing(),
                             TypeEvalContext.userInitiated(element.getProject(), element.getContainingFile()).withTracing());