From f79003b3129ddfeeae61218b46f59de9bee54bf4 Mon Sep 17 00:00:00 2001 From: Dmitry Zhuravlev Date: Fri, 29 May 2026 21:40:48 +0200 Subject: [PATCH] [agent-workbench][ai-code-review]: add ability to route Agent Workbench AI Review into the AI Code Review plugin (IJPL-247008) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Behind the opt-in `ai.review.via.ai.code.review.plugin` registry flag, Agent Workbench's "AI Review" now publishes into the AI Code Review findings bus (Problems view, editor inlays, quick-fixes) instead of parsing JSON findings from the agent's text output into its own tabs. Both plugins keep working independently: the integration lives in an optional content module that loads only when AI Code Review and the MCP server are present, and the routing decision sits behind an extension point in non-optional Agent Workbench code, so neither plugin gains a hard dependency on the other. The bridge keeps Agent Workbench's chosen ACP agent, wires the IDE MCP server into the ACP session restricted to the review tools, and points the agent at the bundled `idea-review` skill on disk so the skill itself defines scope, anchors and fixes — the `/idea-review` slash command is not expanded over ACP. Scope follows the entry point: working-tree changes map to an `uncommitted` scope, an already-committed VCS Log selection to a `file` scope. The session is pre-created through `ReviewSessionLauncher`, tagged created-by-mcp so the Problems view shows the in-progress state immediately, and finalized to completed when the one-shot review turn ends. GitOrigin-RevId: 472bbfae2382c50aae4bde7cf91f8498ae6c3e10 --- .../ai-review/resources/intellij.agent.workbench.ai.review.xml | 3 +++ plugins/agent-workbench/plugin/resources/META-INF/plugin.xml | 1 + 2 files changed, 4 insertions(+) diff --git a/plugins/agent-workbench/ai-review/resources/intellij.agent.workbench.ai.review.xml b/plugins/agent-workbench/ai-review/resources/intellij.agent.workbench.ai.review.xml index 344f5f514e73..296aa795f1aa 100644 --- a/plugins/agent-workbench/ai-review/resources/intellij.agent.workbench.ai.review.xml +++ b/plugins/agent-workbench/ai-review/resources/intellij.agent.workbench.ai.review.xml @@ -25,6 +25,9 @@ + diff --git a/plugins/agent-workbench/plugin/resources/META-INF/plugin.xml b/plugins/agent-workbench/plugin/resources/META-INF/plugin.xml index 88ecd4a2fb9a..ea86f2d39b02 100644 --- a/plugins/agent-workbench/plugin/resources/META-INF/plugin.xml +++ b/plugins/agent-workbench/plugin/resources/META-INF/plugin.xml @@ -59,6 +59,7 @@ +