From f703abb2c30174e5f47364adf68e8bec58e45c98 Mon Sep 17 00:00:00 2001 From: Dmitry Jemerov Date: Thu, 8 Sep 2011 15:55:57 +0200 Subject: [PATCH] no one seems to be interested in hiding the dumb mode notification balloon, so remove it from the API --- .../intellij/openapi/project/DumbService.java | 3 +-- .../openapi/project/DumbServiceImpl.java | 16 ++-------------- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/platform/platform-api/src/com/intellij/openapi/project/DumbService.java b/platform/platform-api/src/com/intellij/openapi/project/DumbService.java index bee2ec8eb9d1..aabea9d08e61 100644 --- a/platform/platform-api/src/com/intellij/openapi/project/DumbService.java +++ b/platform/platform-api/src/com/intellij/openapi/project/DumbService.java @@ -19,7 +19,6 @@ import com.intellij.openapi.Disposable; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.ModalityState; import com.intellij.openapi.components.ServiceManager; -import com.intellij.openapi.ui.popup.BalloonHandler; import com.intellij.openapi.util.NotNullLazyKey; import com.intellij.util.messages.Topic; import org.jetbrains.annotations.NotNull; @@ -139,7 +138,7 @@ public abstract class DumbService { }); } - public abstract BalloonHandler showDumbModeNotification(String message); + public abstract void showDumbModeNotification(String message); public abstract Project getProject(); diff --git a/platform/platform-impl/src/com/intellij/openapi/project/DumbServiceImpl.java b/platform/platform-impl/src/com/intellij/openapi/project/DumbServiceImpl.java index a2b8636e9ca2..d84b2e20eaa9 100644 --- a/platform/platform-impl/src/com/intellij/openapi/project/DumbServiceImpl.java +++ b/platform/platform-impl/src/com/intellij/openapi/project/DumbServiceImpl.java @@ -25,7 +25,6 @@ import com.intellij.openapi.fileEditor.ex.FileEditorManagerEx; import com.intellij.openapi.progress.*; import com.intellij.openapi.progress.util.ProgressIndicatorBase; import com.intellij.openapi.ui.MessageType; -import com.intellij.openapi.ui.popup.BalloonHandler; import com.intellij.openapi.util.Ref; import com.intellij.openapi.util.ShutDownTracker; import com.intellij.openapi.wm.AppIconScheme; @@ -219,21 +218,10 @@ public class DumbServiceImpl extends DumbService { } @Override - public BalloonHandler showDumbModeNotification(final String message) { - final BalloonHandler emptyBalloonHandler = new BalloonHandler() { - public void hide() { - } - }; - if (ApplicationManager.getApplication().isUnitTestMode() || ApplicationManager.getApplication().isHeadlessEnvironment()) { - return emptyBalloonHandler; - } - + public void showDumbModeNotification(final String message) { final IdeFrame ideFrame = WindowManager.getInstance().getIdeFrame(myProject); - if (ideFrame == null) { - return emptyBalloonHandler; - } StatusBarEx statusBar = (StatusBarEx)ideFrame.getStatusBar(); - return statusBar.notifyProgressByBalloon(MessageType.WARNING, message, null, null); + statusBar.notifyProgressByBalloon(MessageType.WARNING, message, null, null); } private static final Ref NULL_ACTION = new Ref(null);