From f701aaad1aff7cbb16999af517221b975a7acd77 Mon Sep 17 00:00:00 2001 From: Julia Beliaeva Date: Tue, 8 Aug 2017 22:58:47 +0300 Subject: [PATCH] [vcs-log] remove unnecessary findLogUi method --- .../git4idea/log/GitShowCommitInLogAction.java | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/plugins/git4idea/src/git4idea/log/GitShowCommitInLogAction.java b/plugins/git4idea/src/git4idea/log/GitShowCommitInLogAction.java index 5e0dc844bbb2..5590179734cc 100644 --- a/plugins/git4idea/src/git4idea/log/GitShowCommitInLogAction.java +++ b/plugins/git4idea/src/git4idea/log/GitShowCommitInLogAction.java @@ -65,8 +65,9 @@ public class GitShowCommitInLogAction extends DumbAwareAction { return; } - boolean logReady = findLogUi(project) != null; - + VcsProjectLog projectLog = VcsProjectLog.getInstance(project); + boolean logReady = projectLog.getMainLogUi() != null; + ToolWindow window = ToolWindowManager.getInstance(project).getToolWindow(ChangesViewContentManager.TOOLWINDOW_ID); ContentManager cm = window.getContentManager(); Content[] contents = cm.getContents(); @@ -77,7 +78,7 @@ public class GitShowCommitInLogAction extends DumbAwareAction { } } - VcsLogUiImpl logUi = findLogUi(project); + VcsLogUiImpl logUi = projectLog.getMainLogUi(); if (logUi == null) { showLogNotReadyMessage(project); return; @@ -133,15 +134,6 @@ public class GitShowCommitInLogAction extends DumbAwareAction { Comparing.equal(getVcsKey(e), GitVcs.getKey())); } - @Nullable - private static VcsLogUiImpl findLogUi(@NotNull Project project) { - VcsProjectLog projectLog = VcsProjectLog.getInstance(project); - if (projectLog != null) { - return projectLog.getMainLogUi(); - } - return null; - } - private static void jumpToRevisionUnderProgress(@NotNull Project project, @NotNull VcsLogUiImpl logUi, @NotNull VcsRevisionNumber revision) {