diff --git a/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/AbstractJavaFxPackager.java b/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/AbstractJavaFxPackager.java index be6c50010aae..a176b9c419d4 100644 --- a/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/AbstractJavaFxPackager.java +++ b/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/AbstractJavaFxPackager.java @@ -45,6 +45,8 @@ public abstract class AbstractJavaFxPackager { protected String getArtifactRootName() { return PathUtilRt.getFileName(getArtifactOutputFilePath()); } + + protected abstract String getArtifactName(); protected abstract String getArtifactOutputPath(); @@ -102,9 +104,8 @@ public abstract class AbstractJavaFxPackager { .append("classpath=\"").append(homePath).append("/lib/ant-javafx.jar\"/>\n"); buf.append(""); final String artifactFileName = getArtifactRootName(); - final String artifactName = FileUtil.getNameWithoutExtension(artifactFileName); final List tags = - JavaFxAntGenerator.createJarAndDeployTasks(this, artifactFileName, artifactName, tempUnzippedArtifactOutput.getPath()); + JavaFxAntGenerator.createJarAndDeployTasks(this, artifactFileName, getArtifactName(), tempUnzippedArtifactOutput.getPath()); for (JavaFxAntGenerator.SimpleTag tag : tags) { tag.generate(buf); } diff --git a/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/JavaFxAntGenerator.java b/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/JavaFxAntGenerator.java index 01ff08300845..e9f50e748f04 100644 --- a/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/JavaFxAntGenerator.java +++ b/plugins/javaFX/common-javaFX-plugin/src/org/jetbrains/plugins/javaFX/packaging/JavaFxAntGenerator.java @@ -16,6 +16,7 @@ package org.jetbrains.plugins.javaFX.packaging; import com.intellij.openapi.util.Pair; +import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.util.text.StringUtil; import java.io.File; @@ -35,6 +36,7 @@ public class JavaFxAntGenerator { String artifactFileName, String artifactName, String tempDirPath) { + final String artifactFileNameWithoutExtension = FileUtil.getNameWithoutExtension(artifactFileName); final List topLevelTagsCollector = new ArrayList(); final String preloaderJar = packager.getPreloaderJar(); final String preloaderClass = packager.getPreloaderClass(); @@ -42,21 +44,21 @@ public class JavaFxAntGenerator { String allButPreloader = null; if (!StringUtil.isEmptyOrSpaces(preloaderJar) && !StringUtil.isEmptyOrSpaces(preloaderClass)) { - preloaderFiles = artifactName + "_preloader_files"; + preloaderFiles = artifactFileNameWithoutExtension + "_preloader_files"; topLevelTagsCollector.add(new SimpleTag("fx:fileset", new Pair("id", preloaderFiles), new Pair("requiredFor", "preloader"), new Pair("dir", tempDirPath), new Pair("includes", preloaderJar))); - allButPreloader = "all_but_preloader_" + artifactName; + allButPreloader = "all_but_preloader_" + artifactFileNameWithoutExtension; topLevelTagsCollector.add(new SimpleTag("fx:fileset", new Pair("id", allButPreloader), new Pair("dir", tempDirPath), new Pair("excludes", preloaderJar), new Pair("includes", "**/*.jar"))); } - final String allButSelf = "all_but_" + artifactName; + final String allButSelf = "all_but_" + artifactFileNameWithoutExtension; final SimpleTag allButSelfAndPreloader = new SimpleTag("fx:fileset", new Pair("id", allButSelf), new Pair("dir", tempDirPath), new Pair("includes", "**/*.jar")); @@ -66,14 +68,14 @@ public class JavaFxAntGenerator { } topLevelTagsCollector.add(allButSelfAndPreloader); - final String all = "all_" + artifactName; + final String all = "all_" + artifactFileNameWithoutExtension; final SimpleTag allIncluded = new SimpleTag("fx:fileset", new Pair("id", all), new Pair("dir", tempDirPath), new Pair("includes", "**/*.jar")); topLevelTagsCollector.add(allIncluded); //register application - final String appId = artifactName + "_id"; + final String appId = artifactFileNameWithoutExtension + "_id"; final SimpleTag applicationTag = new SimpleTag("fx:application", new Pair("id", appId), new Pair("name", artifactName), new Pair("mainClass", packager.getAppClass())); @@ -113,7 +115,7 @@ public class JavaFxAntGenerator { new Pair("height", packager.getHeight()), new Pair("updatemode", packager.getUpdateMode()), new Pair("outdir", tempDirPath + File.separator + "deploy"), - new Pair("outfile", artifactName)); + new Pair("outfile", artifactFileNameWithoutExtension)); final JavaFxPackagerConstants.NativeBundles bundle = packager.getNativeBundle(); if (bundle != JavaFxPackagerConstants.NativeBundles.none) { deployTag.addAttribute(new Pair("nativeBundles", bundle.name())); diff --git a/plugins/javaFX/javaFX-CE/testSrc/org/jetbrains/plugins/javaFX/packaging/JavaFxAntTaskTest.java b/plugins/javaFX/javaFX-CE/testSrc/org/jetbrains/plugins/javaFX/packaging/JavaFxAntTaskTest.java index 0c58204fbc17..ac4dc5970d8c 100644 --- a/plugins/javaFX/javaFX-CE/testSrc/org/jetbrains/plugins/javaFX/packaging/JavaFxAntTaskTest.java +++ b/plugins/javaFX/javaFX-CE/testSrc/org/jetbrains/plugins/javaFX/packaging/JavaFxAntTaskTest.java @@ -251,7 +251,12 @@ public class JavaFxAntTaskTest extends UsefulTestCase{ public void setSigned(boolean signed) { mySigned = signed; } - + + @Override + protected String getArtifactName() { + return getArtifactRootName(); + } + @Override protected String getArtifactOutputPath() { return new File(myOutputPath).getParent(); diff --git a/plugins/javaFX/javaFX-jps-plugin/src/org/jetbrains/plugins/javaFX/JpsJavaFxArtifactBuildTaskProvider.java b/plugins/javaFX/javaFX-jps-plugin/src/org/jetbrains/plugins/javaFX/JpsJavaFxArtifactBuildTaskProvider.java index 7e961f1fe821..06148e7eaec9 100644 --- a/plugins/javaFX/javaFX-jps-plugin/src/org/jetbrains/plugins/javaFX/JpsJavaFxArtifactBuildTaskProvider.java +++ b/plugins/javaFX/javaFX-jps-plugin/src/org/jetbrains/plugins/javaFX/JpsJavaFxArtifactBuildTaskProvider.java @@ -108,6 +108,11 @@ public class JpsJavaFxArtifactBuildTaskProvider extends ArtifactBuildTaskProvide myCompileContext = compileContext; } + @Override + protected String getArtifactName() { + return myArtifact.getName(); + } + @Override protected String getArtifactOutputPath() { return myArtifact.getOutputPath(); diff --git a/plugins/javaFX/src/org/jetbrains/plugins/javaFX/packaging/JavaFxArtifactProperties.java b/plugins/javaFX/src/org/jetbrains/plugins/javaFX/packaging/JavaFxArtifactProperties.java index 9bfeac0a31f0..d3227b99ccf8 100644 --- a/plugins/javaFX/src/org/jetbrains/plugins/javaFX/packaging/JavaFxArtifactProperties.java +++ b/plugins/javaFX/src/org/jetbrains/plugins/javaFX/packaging/JavaFxArtifactProperties.java @@ -309,6 +309,11 @@ public class JavaFxArtifactProperties extends ArtifactProperties tags = - JavaFxAntGenerator.createJarAndDeployTasks(javaFxPackager, artifactFileName, artifactName, tempDirPath); + JavaFxAntGenerator.createJarAndDeployTasks(javaFxPackager, artifactFileName, artifact.getName(), tempDirPath); for (JavaFxAntGenerator.SimpleTag tag : tags) { buildTags(generator, tag); }