From f5e8ce0d1f83f37a30291e5a1f243e683511093e Mon Sep 17 00:00:00 2001 From: peter Date: Mon, 17 Feb 2014 20:57:43 +0100 Subject: [PATCH] PathMacroMap: add clarifying comments about by-reference string comparison --- .../src/com/intellij/openapi/components/PathMacroMap.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jps/model-serialization/src/com/intellij/openapi/components/PathMacroMap.java b/jps/model-serialization/src/com/intellij/openapi/components/PathMacroMap.java index 896052315e5c..4793055677e1 100644 --- a/jps/model-serialization/src/com/intellij/openapi/components/PathMacroMap.java +++ b/jps/model-serialization/src/com/intellij/openapi/components/PathMacroMap.java @@ -47,7 +47,7 @@ public abstract class PathMacroMap { String newText = (recursively || (filter != null && filter.recursePathMacros(t))) ? substituteRecursively(oldText, caseSensitive) : substitute(oldText, caseSensitive); - if (oldText != newText) { + if (oldText != newText) { // if the string was changed t.setText(newText); } } @@ -63,7 +63,7 @@ public abstract class PathMacroMap { String newValue = (recursively || (filter != null && filter.recursePathMacros(attribute))) ? substituteRecursively(oldValue, caseSensitive) : substitute(oldValue, caseSensitive); - if (oldValue != newValue) { + if (oldValue != newValue) { // if the string was changed attribute.setValue(newValue); } }