From f5df846532f2154bebf5cb53e0ae7562d5c11bde Mon Sep 17 00:00:00 2001 From: Alexander Zolotov Date: Mon, 30 Mar 2015 18:29:25 +0300 Subject: [PATCH] Remove redundant isValid checking --- .../src/com/intellij/refactoring/IntroduceTargetChooser.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/refactoring/IntroduceTargetChooser.java b/platform/lang-impl/src/com/intellij/refactoring/IntroduceTargetChooser.java index 273bd5a52e98..8a552425523b 100644 --- a/platform/lang-impl/src/com/intellij/refactoring/IntroduceTargetChooser.java +++ b/platform/lang-impl/src/com/intellij/refactoring/IntroduceTargetChooser.java @@ -89,7 +89,7 @@ public class IntroduceTargetChooser { final Component rendererComponent = super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus); SmartPsiElementPointer pointer = (SmartPsiElementPointer)value; final T expr = pointer.getElement(); - if (expr != null && expr.isValid()) { + if (expr != null) { String text = renderer.fun(expr); int firstNewLinePos = text.indexOf('\n'); String trimmedText = text.substring(0, firstNewLinePos != -1 ? firstNewLinePos : Math.min(100, text.length())); @@ -112,7 +112,7 @@ public class IntroduceTargetChooser { if (index < 0) return; SmartPsiElementPointer pointer = ((SmartPsiElementPointer)model.get(index)); final T expr = pointer.getElement(); - if (expr != null && expr.isValid()) { + if (expr != null) { highlighter.highlight(expr, Collections.singletonList(expr)); } }