From f368f326dc21903baacd4cfc71bb0dce881a4a39 Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Fri, 27 Oct 2017 20:18:47 +0200 Subject: [PATCH] follow IDEA-CR-26141 --- .../codeInsight/daemon/impl/analysis/HighlightClassUtil.java | 5 ++--- .../daemonCodeAnalyzer/genericsHighlighting/Enum.java | 2 +- .../daemonCodeAnalyzer/genericsHighlighting8/Enum.java | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightClassUtil.java b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightClassUtil.java index 98dbdd7e1f32..d3be6b98f91e 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightClassUtil.java +++ b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightClassUtil.java @@ -479,9 +479,8 @@ public class HighlightClassUtil { @Nullable static HighlightInfo checkCannotInheritFromFinal(PsiClass superClass, PsiElement elementToHighlight) { HighlightInfo errorResult = null; - boolean isFinal = superClass.hasModifierProperty(PsiModifier.FINAL); - if (isFinal || superClass.isEnum()) { - String message = JavaErrorMessages.message("inheritance.from.final.class", superClass.getQualifiedName(), isFinal ? PsiKeyword.FINAL : PsiKeyword.ENUM); + if (superClass.hasModifierProperty(PsiModifier.FINAL) || superClass.isEnum()) { + String message = JavaErrorMessages.message("inheritance.from.final.class", superClass.getQualifiedName(), superClass.isEnum() ? PsiKeyword.ENUM : PsiKeyword.FINAL); errorResult = HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR).range(elementToHighlight).descriptionAndTooltip(message).create(); QuickFixAction.registerQuickFixAction(errorResult, diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting/Enum.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting/Enum.java index 09b0ad9e5513..c916c17769b6 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting/Enum.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting/Enum.java @@ -38,7 +38,7 @@ enum Operation { void valueOf(String s) {} } -class exte extends Operation { +class exte extends Operation { } enum withConstant { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting8/Enum.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting8/Enum.java index 168f4fd498d0..98305d0530d8 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting8/Enum.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/genericsHighlighting8/Enum.java @@ -38,7 +38,7 @@ enum Operation { void valueOf(String s) {} } -class exte extends Operation { +class exte extends Operation { } class use {