From f234552ee1e4c1698bd0470b7e9961c2dbd07a00 Mon Sep 17 00:00:00 2001 From: Semyon Proshev Date: Fri, 30 Apr 2021 00:05:06 +0300 Subject: [PATCH] Do not override InspectionProfileEntry.isEnabledByDefault in python inspections due to its javadoc GitOrigin-RevId: 851edaf9034d63d7754bfc410373f3721eb03e68 --- .../inspections/PyArgumentEqualDefaultInspection.java | 5 ----- .../python/inspections/PyAugmentAssignmentInspection.java | 5 ----- .../python/inspections/PyClassicStyleClassInspection.java | 5 ----- .../python/inspections/PyCompatibilityInspection.java | 5 ----- .../python/inspections/PyDocstringTypesInspection.java | 5 ----- .../com/jetbrains/python/inspections/PyInspection.java | 5 ----- .../python/inspections/PyMandatoryEncodingInspection.java | 5 ----- .../com/jetbrains/rest/inspections/RestInspection.java | 8 ++------ .../jetbrains/rest/inspections/RestRoleInspection.java | 5 ----- .../inspection/BuildoutUnresolvedPartInspection.java | 5 ----- 10 files changed, 2 insertions(+), 51 deletions(-) diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyArgumentEqualDefaultInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyArgumentEqualDefaultInspection.java index 5f74abec5080..a4e5033ba225 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyArgumentEqualDefaultInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyArgumentEqualDefaultInspection.java @@ -43,11 +43,6 @@ public class PyArgumentEqualDefaultInspection extends PyInspection { return new Visitor(holder, session); } - @Override - public boolean isEnabledByDefault() { - return false; - } - private static class Visitor extends PyInspectionVisitor { Visitor(@Nullable ProblemsHolder holder, @NotNull LocalInspectionToolSession session) { super(holder, session); diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyAugmentAssignmentInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyAugmentAssignmentInspection.java index 02ed3ebda882..229edd30193a 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyAugmentAssignmentInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyAugmentAssignmentInspection.java @@ -160,9 +160,4 @@ public class PyAugmentAssignmentInspection extends PyInspection { return PyTypeChecker.match(cache.getComplexType(), type, myTypeEvalContext); } } - - @Override - public boolean isEnabledByDefault() { - return false; - } } diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyClassicStyleClassInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyClassicStyleClassInspection.java index 48e0a95d50e0..c8c19fc705f1 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyClassicStyleClassInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyClassicStyleClassInspection.java @@ -31,11 +31,6 @@ import org.jetbrains.annotations.Nullable; */ public class PyClassicStyleClassInspection extends PyInspection { - @Override - public boolean isEnabledByDefault() { - return false; - } - @NotNull @Override public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java index eb55c6221693..040a76ce53fd 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java @@ -99,11 +99,6 @@ public class PyCompatibilityInspection extends PyInspection { return (PyCompatibilityInspection)inspectionProfile.getUnwrappedTool(toolName, element); } - @Override - public boolean isEnabledByDefault() { - return false; - } - private List updateVersionsToProcess() { List result = new ArrayList<>(); diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyDocstringTypesInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyDocstringTypesInspection.java index b03b4a4f7007..b6cf096cfae3 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyDocstringTypesInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyDocstringTypesInspection.java @@ -26,11 +26,6 @@ import org.jetbrains.annotations.Nullable; public class PyDocstringTypesInspection extends PyInspection { - @Override - public boolean isEnabledByDefault() { - return false; - } - @NotNull @Override public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyInspection.java index 8c02413a9284..afe56cbb9b16 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyInspection.java @@ -49,11 +49,6 @@ public abstract class PyInspection extends LocalInspectionTool { return getClass().getSimpleName(); } - @Override - public boolean isEnabledByDefault() { - return true; - } - @Override public boolean isSuppressedFor(@NotNull PsiElement element) { final PsiFile file = element.getContainingFile(); diff --git a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyMandatoryEncodingInspection.java b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyMandatoryEncodingInspection.java index acadca6ae0d2..e560b14b2eb6 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/inspections/PyMandatoryEncodingInspection.java +++ b/python/python-psi-impl/src/com/jetbrains/python/inspections/PyMandatoryEncodingInspection.java @@ -39,11 +39,6 @@ import java.awt.event.ActionListener; */ public class PyMandatoryEncodingInspection extends PyInspection { - @Override - public boolean isEnabledByDefault() { - return true; - } - @NotNull @Override public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, diff --git a/python/python-rest/src/com/jetbrains/rest/inspections/RestInspection.java b/python/python-rest/src/com/jetbrains/rest/inspections/RestInspection.java index bffdddd6fd50..0e2c71ef3340 100644 --- a/python/python-rest/src/com/jetbrains/rest/inspections/RestInspection.java +++ b/python/python-rest/src/com/jetbrains/rest/inspections/RestInspection.java @@ -15,7 +15,8 @@ */ package com.jetbrains.rest.inspections; -import com.intellij.codeInspection.*; +import com.intellij.codeInspection.LocalInspectionTool; +import com.intellij.codeInspection.SuppressQuickFix; import com.intellij.psi.PsiElement; import com.jetbrains.rest.RestBundle; import org.jetbrains.annotations.Nls; @@ -39,11 +40,6 @@ public abstract class RestInspection extends LocalInspectionTool { return getClass().getSimpleName(); } - @Override - public boolean isEnabledByDefault() { - return true; - } - @Override public SuppressQuickFix @NotNull [] getBatchSuppressActions(@Nullable PsiElement element) { return SuppressQuickFix.EMPTY_ARRAY; diff --git a/python/python-rest/src/com/jetbrains/rest/inspections/RestRoleInspection.java b/python/python-rest/src/com/jetbrains/rest/inspections/RestRoleInspection.java index 5f60837ebd95..959e0c7f6ecb 100644 --- a/python/python-rest/src/com/jetbrains/rest/inspections/RestRoleInspection.java +++ b/python/python-rest/src/com/jetbrains/rest/inspections/RestRoleInspection.java @@ -53,11 +53,6 @@ import java.util.Set; public class RestRoleInspection extends RestInspection { public JDOMExternalizableStringList ignoredRoles = new JDOMExternalizableStringList(); - @Override - public boolean isEnabledByDefault() { - return false; - } - @NotNull @Override public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) { diff --git a/python/src/com/jetbrains/python/buildout/config/inspection/BuildoutUnresolvedPartInspection.java b/python/src/com/jetbrains/python/buildout/config/inspection/BuildoutUnresolvedPartInspection.java index 62c719a7ee5a..d09a2dcba1cb 100644 --- a/python/src/com/jetbrains/python/buildout/config/inspection/BuildoutUnresolvedPartInspection.java +++ b/python/src/com/jetbrains/python/buildout/config/inspection/BuildoutUnresolvedPartInspection.java @@ -33,11 +33,6 @@ public class BuildoutUnresolvedPartInspection extends LocalInspectionTool { return "BuildoutUnresolvedPartInspection"; } - @Override - public boolean isEnabledByDefault() { - return true; - } - @Override public ProblemDescriptor[] checkFile(@NotNull PsiFile file, @NotNull InspectionManager manager, boolean isOnTheFly) { List problems = new ArrayList<>();