From efd7e800e76d8c4a4ea5388294b0697f949e086c Mon Sep 17 00:00:00 2001 From: "Denis.Zhdanov" Date: Tue, 6 Mar 2012 14:31:31 +0400 Subject: [PATCH] IDEA-76142: Gradle support - cannot update IDEA projects once one of build.gradle files changes Cleanup --- ...leAbstractDependencyStructureChangesCalculator.java | 1 - .../GradleContentRootStructureChangesCalculator.java | 1 - .../diff/GradleModuleStructureChangesCalculator.java | 1 - .../plugins/gradle/remote/GradleApiFacadeManager.java | 2 +- .../gradle/sync/GradleProjectStructureTreeModel.java | 4 ---- .../org/jetbrains/plugins/gradle/util/GradleUtil.java | 10 ++++++++-- 6 files changed, 9 insertions(+), 10 deletions(-) diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/diff/GradleAbstractDependencyStructureChangesCalculator.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/diff/GradleAbstractDependencyStructureChangesCalculator.java index e982b0022e79..d4814b6a4b9f 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/diff/GradleAbstractDependencyStructureChangesCalculator.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/diff/GradleAbstractDependencyStructureChangesCalculator.java @@ -16,7 +16,6 @@ public abstract class GradleAbstractDependencyStructureChangesCalculator gradleContentRoots = gradleEntity.getContentRoots(); final Collection intellijContentRoots = context.getPlatformFacade().getContentRoots(intellijEntity); diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/remote/GradleApiFacadeManager.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/remote/GradleApiFacadeManager.java index b8488781f219..3f884ccec8b2 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/remote/GradleApiFacadeManager.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/remote/GradleApiFacadeManager.java @@ -171,7 +171,7 @@ public class GradleApiFacadeManager { final GeneralCommandLine commandLine = JdkUtil.setupJVMCommandLine( ((JavaSdkType)sdk.getSdkType()).getVMExecutablePath(sdk), params, - false // TODO den check + false ); final OSProcessHandler processHandler = new OSProcessHandler(commandLine.createProcess(), commandLine.getCommandLineString()) { @Override diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/sync/GradleProjectStructureTreeModel.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/sync/GradleProjectStructureTreeModel.java index 3f74a6e2adb7..1bb6991fb5ae 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/sync/GradleProjectStructureTreeModel.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/sync/GradleProjectStructureTreeModel.java @@ -241,11 +241,9 @@ public class GradleProjectStructureTreeModel extends DefaultTreeModel { } private void processNewProjectRenameChange(@NotNull GradleProjectRenameChange change) { - // TODO den implement } private void processNewLanguageLevelChange(@NotNull GradleLanguageLevelChange change) { - // TODO den implement } private void processNewMismatchedLibraryPathChange(@NotNull GradleMismatchedLibraryPathChange change) { @@ -325,11 +323,9 @@ public class GradleProjectStructureTreeModel extends DefaultTreeModel { } private void processObsoleteProjectRenameChange(@NotNull GradleProjectRenameChange change) { - // TODO den implement } private void processObsoleteLanguageLevelChange(@NotNull GradleLanguageLevelChange change) { - // TODO den implement } private void processObsoleteMismatchedLibraryPathChange(@NotNull GradleMismatchedLibraryPathChange change) { diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/util/GradleUtil.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/util/GradleUtil.java index 902e8027ad48..505bff71191b 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/util/GradleUtil.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/util/GradleUtil.java @@ -256,8 +256,14 @@ public class GradleUtil { } return file.getPath(); } - - // TODO den add doc about relative coordinates + + /** + * Allows to calculate the position to use for showing hint for the given node of the given tree. + * + * @param node target node for which a hint should be shown + * @param tree target tree that contains given node + * @return preferred hint position (in coordinates relative to the given tree) + */ @NotNull public static Point getHintPosition(@NotNull GradleProjectStructureNode node, @NotNull Tree tree) { final Rectangle bounds = tree.getPathBounds(new TreePath(node.getPath()));